Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Some checks are not being executed on all merges #609

Open
claudioandre-br opened this issue Nov 15, 2024 · 7 comments
Open

[BUG]: Some checks are not being executed on all merges #609

claudioandre-br opened this issue Nov 15, 2024 · 7 comments
Labels
bug Something isn't working Done Our work is done. Should close soon. No longer happening or existing. external issues Only an external entity can solve the problem properly

Comments

@claudioandre-br
Copy link
Member

claudioandre-br commented Nov 15, 2024

Which version of the application are you using?

1.9J1+2404, latest bleeding

Description of the bug

Some checks are not being executed on all merges. We have already detected problems in these cases:

  • Trivy rootfs
  • Trivy SBOM
  • Supply chain / scorecard

Sometimes I'm pushing to main and sometimes not?

GitHub isn't doing what it should. Anyway, we can think of an alternative solution (workaround).

Examples:

The difference between these two points in time:

https://github.com/openwall/john-packages/compare/6579932baa008b74512119bbaa250427c6d1313c..cdb3a83e872a3ceb34fb9216d12c8372ca45bc26

Nothing that could be our fault.

Steps To Reproduce

No response

Your execution environment

No response

@claudioandre-br claudioandre-br added bug Something isn't working external issues Only an external entity can solve the problem properly labels Nov 15, 2024
Copy link

Welcome and thank you for helping us improve our software.

Please make sure you read and understand the CODE_OF_CONDUCT.md and CONTRIBUTING.md.
We hope to see you soon!

@claudioandre-br claudioandre-br changed the title [BUG]: [BUG]: Some checks are not being executed on all mergers Nov 15, 2024
@claudioandre-br claudioandre-br changed the title [BUG]: Some checks are not being executed on all mergers [BUG]: Some checks are not being executed on all merges Nov 15, 2024
@claudioandre-br
Copy link
Member Author

claudioandre-br commented Nov 15, 2024

More examples. History for scorecard.yml:

@claudioandre-br
Copy link
Member Author

claudioandre-br commented Nov 16, 2024

More examples:

  • 13 checks (4 skipped checks):
    ba808f3

  • 12 checks (4 skipped checks):
    55d626c

The event that did not occur (and it has not changed at all):

"on":
pull_request_target:
types: [opened]
issues:
types: [opened]

  1. So a “pull request event” did not happen in the second run?
  2. Is there a cache (where) ?
  3. If a file has a name as a greetings, does some magic happen behind the curtains? 🪄 😱

@claudioandre-br claudioandre-br added the keep open Do NOT close automatically. label Nov 16, 2024
@claudioandre-br
Copy link
Member Author

I will run yaml linters on all workflow files (and I'll accept the suggested corrections).

@claudioandre-br
Copy link
Member Author

claudioandre-br commented Nov 17, 2024

  • It seems that if I use a branch name like fix/name, I can get around the problem. => FALSE [1]
  • The merges made by the merge bot are worse. => FALSE [2]

[1]
It might help a little on some occasions.

[2]
The examples above prove this.

@claudioandre-br
Copy link
Member Author

One commit was skipped:

image

The second commit below is simply IGNORED (the 646):

image

@claudioandre-br
Copy link
Member Author

I've documented the behavior.
There is nothing I can do to improve it or resolve the situation.

@claudioandre-br claudioandre-br added Done Our work is done. Should close soon. No longer happening or existing. and removed keep open Do NOT close automatically. labels Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Done Our work is done. Should close soon. No longer happening or existing. external issues Only an external entity can solve the problem properly
Projects
None yet
Development

No branches or pull requests

1 participant