POC: special case of removing uneffective zeropoint Subtract OP #27943
+196
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: NPU
dmatveev
reviewed
Dec 5, 2024
|
|
||
| //TODO: verify input 0 is subtract | ||
| multiply_node->input(0).replace_source_output(sub_weights_node->output(0)); | ||
| multiply_node->validate_and_infer_types(); |
There was a problem hiding this comment.
this line is probably not required
| auto sub_weights_node = node_to_output.at(sub_weights).get_node_shared_ptr(); | ||
|
|
||
| //TODO: verify input 0 is subtract | ||
| multiply_node->input(0).replace_source_output(sub_weights_node->output(0)); |
There was a problem hiding this comment.
->input(0) seems ok - i think i've tried both cases, sub_weights_node and sub_weights_node->output(0), as well. Will check one more time.
esmirno
commented
Dec 6, 2024
| LOG_DEBUG("UneffectiveZP subgraph detected with NOP zp tensor: " | ||
| << zero_point_tensor_node->get_friendly_name() << " shape=" << zero_point_tensor_node->get_shape()); | ||
| // removing whole zubgraph with subtract + zeropoints | ||
| auto multiply_node = node_to_output.at(subtract).get_node_shared_ptr(); |
There was a problem hiding this comment.
@dmatveev looks here was a typo - subtract instead of multiply
+fixes in UneffectiveZp matcher
-extra optional reshape remove.
+bathless params dims produced by partitioner while replacing const by params, by squeesing uneffective dims, and the inserting reshape
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: