Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When used msvc clang-cl, kernel a64_fp16_4x4_3x3 isn't built #1135

Closed
allnes opened this issue Aug 12, 2024 · 6 comments · May be fixed by openvinotoolkit/openvino#27858
Closed

When used msvc clang-cl, kernel a64_fp16_4x4_3x3 isn't built #1135

allnes opened this issue Aug 12, 2024 · 6 comments · May be fixed by openvinotoolkit/openvino#27858
Assignees
@morgolock
Labels
Feature Request Help wanted

Comments

@allnes
Copy link

allnes commented Aug 12, 2024

Hi,
I used Windows system on Snapdragon ARM CPU and noticed that kernel can't build:
arm_conv::winograd::weight_transform::a64_fp16_4x4_3x3
and other fp16 kernels in:
src/core/NEON/kernels/convolution/winograd/input_transforms
src/core/NEON/kernels/convolution/winograd/output_transforms
src/core/NEON/kernels/convolution/winograd/weight_transforms
This problem create failure of our build in OpenVINO on this system.
Could you tell are there reasons for that?
@allnes allnes mentioned this issue Aug 12, 2024
Merged
@morgolock morgolock self-assigned this Aug 12, 2024
@morgolock
Copy link

Hi @allnes

Presently we support only armv8a targets for Windows, could you please let us know which options are you using to build ACL when you see this error?

@allnes
Copy link
Author

allnes commented Aug 12, 2024

Hi this command was generated:
scons neon=1 opencl=0 openmp=0 cppthreads=1 examples=0 Werror=0 gemm_tuner=0 reference_openmp=0 validation_tests=0 benchmark_tests=0 data_layout_support=all arch=arm64-v8.2-a estate=64 os=windows build=native

@allnes
Copy link
Author

allnes commented Aug 12, 2024

armv8a arch disable fp16 kernels, do you have plan to support arm64-v8.2-a instruction set?

@allnes allnes changed the title When used msvc clan-cl, kernel a64_fp16_4x4_3x3 isn't built When used msvc clang-cl, kernel a64_fp16_4x4_3x3 isn't built Aug 12, 2024
@morgolock
Copy link

HI @allnes

Yes, we will look into adding support for arm64-v8.2-a

@morgolock
Copy link

Hi @allnes

The following patch fixes the linker errors.

Hope this helps.

@allnes
Copy link
Author

allnes commented Aug 14, 2024

Hi @morgolock

Thank you, patch is worked, we'll wait for the release

@morgolock morgolock added this to the v24.11 milestone Aug 14, 2024
@allnes allnes mentioned this issue Dec 2, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@morgolock morgolock

Labels
Feature Request Help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ARM][CPU] Fix build paths for ACLConfig allnes/openvino
2 participants
@morgolock @allnes