Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix View Switcher #977

Merged
merged 6 commits into from
Aug 28, 2023
Merged

Fix View Switcher #977

merged 6 commits into from
Aug 28, 2023

Conversation

binh-dam-ibigroup
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup commented Aug 18, 2023

Description

This PR fixes issues around the "Plan Trip" view switcher button.
With this PR, the following actions are now possible:

  • From "Account" > "Trips" > "Edit a trip", "Plan Trip" is no longer highlighted, and clicking "Plan Trip" returns to the plan view, showing any previously active itineraries.
  • After returning to a plan view from the trips (or other account page), clicking the browser's "Back" button once returns to that account page.

These actions should still be possible:

  • With an active itinerary shown, after planning an other itinerary (e.g. by changing the start/end point), clicking the browser's "Back" button once still brings back the previously shown itinerary.
  • Navigating to and from the Route Viewer is still possible, with UI response by clicking the browser's "Back" button once.

PR Checklist

  • [na] Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • [na] Are all languages supported (Internationalization/Localization)?
  • [na] Are appropriate Typescript types implemented?

Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Having trouble testing some of the potential actions in the description due to what looks like an unrelated bug with saving trips, but everything around view switcher highlight on account page and back button navigation LGTM!

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement, some cleanup in here that I recently was dealing with.

@binh-dam-ibigroup binh-dam-ibigroup merged commit fe4e7bf into dev Aug 28, 2023
@binh-dam-ibigroup binh-dam-ibigroup deleted the fix-view-switcher branch August 28, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants