-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix View Switcher #977
Fix View Switcher #977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Having trouble testing some of the potential actions in the description due to what looks like an unrelated bug with saving trips, but everything around view switcher highlight on account page and back button navigation LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvement, some cleanup in here that I recently was dealing with.
Description
This PR fixes issues around the "Plan Trip" view switcher button.
With this PR, the following actions are now possible:
These actions should still be possible:
PR Checklist