Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to OTP2 Trip Props #968

Merged
merged 10 commits into from
Sep 15, 2023
Merged

Migrate to OTP2 Trip Props #968

merged 10 commits into from
Sep 15, 2023

Conversation

miles-grant-ibigroup
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup commented Aug 8, 2023

Description:

OTP1 trip props are no longer in use: opentripplanner/otp-ui#640.

This PR makes use of the new props and so allows the trip view to work with the graphQL API.

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

@miles-grant-ibigroup miles-grant-ibigroup added the BLOCKED Blocked (waiting on another PR to be merged) label Aug 8, 2023
@miles-grant-ibigroup miles-grant-ibigroup self-assigned this Aug 8, 2023
@miles-grant-ibigroup miles-grant-ibigroup removed the BLOCKED Blocked (waiting on another PR to be merged) label Sep 12, 2023
@miles-grant-ibigroup
Copy link
Collaborator Author

With otp-ui updates all works again @AdrianaCeric

@AdrianaCeric
Copy link
Member

Ok let me try again

Copy link
Member

@AdrianaCeric AdrianaCeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are so back

lib/components/viewers/trip-viewer.js Outdated Show resolved Hide resolved
lib/components/viewers/trip-viewer.js Show resolved Hide resolved
@miles-grant-ibigroup miles-grant-ibigroup merged commit b04367a into dev Sep 15, 2023
5 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the otp2-trip-migration branch September 15, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants