replace hardcoded 'node_modules' path #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miles-grant-ibigroup
approved these changes
Dec 2, 2024
binh-dam-ibigroup
approved these changes
Dec 2, 2024
|
Tests will fail because it's an external PR but I've run them locally and all seems to work! If it all melts down we can revert |
miles-grant-ibigroup
merged commit c728287
into
opentripplanner:dev
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR aims to replace the hard coded
node_modulespath from the i18n yml require line. This is helpful/necessary if the code isn't imported from the same relative path compared to the node_modules folder. Prefixing the include string with@opentripplannermake the lazy load mechanism find the files.PR Checklist:
No text, logic or UI changes from this change.