Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI not reponding to URL search params changes when navigating back and forth.. #1107

Open
binh-dam-ibigroup opened this issue Jan 5, 2024 · 1 comment

Comments

@binh-dam-ibigroup
Copy link
Collaborator

          Not holding this against this PR, but the search is getting cleared as a result of passing this second param. Although using the browser back navigation command does restore the search params, the UI is not picking those params. I'll file this as a separate issue.

Originally posted by @binh-dam-ibigroup in #1018 (comment)

@daniel-heppner-ibigroup
Copy link
Contributor

daniel-heppner-ibigroup commented Jan 5, 2024

The way routing is handled in general in the app is... not good. There's a lot of glue logic to hold the redux state in sync with the url state, and it doesn't always work.

If we can find a way to fix this that reduces the amount of glue, I think that would be very good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants