Add default penalty to all car api modes #6302
Open
+28
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CAR & CAR_PICKUP can be used in access/egress, but no penalty was set.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6302 +/- ##
=============================================
+ Coverage 69.71% 69.78% +0.07%
- Complexity 17696 17786 +90
=============================================
Files 2008 2017 +9
Lines 75834 76040 +206
Branches 7765 7783 +18
=============================================
+ Hits 52866 53065 +199
- Misses 20256 20267 +11
+ Partials 2712 2708 -4 ☔ View full report in Codecov by Sentry. |
|
Can you use CAR as an access or egress mode? I don't think so. |
According to the api qualified |
|
You're right. I forgot about that one. |
leonardehrenfried
changed the title
leonardehrenfried
approved these changes
Dec 12, 2024
| var penaltyrBuilder = TimeAndCostPenaltyForEnum.of(StreetMode.class); | ||
|
|
||
| var flexDefaultPenalty = TimeAndCostPenalty.of(TimePenalty.of(ofMinutes(10), 1.3f), 1.3); | ||
| penaltyrBuilder.with(StreetMode.FLEXIBLE, flexDefaultPenalty); |
There was a problem hiding this comment.
Suggested change
| penaltyrBuilder.with(StreetMode.FLEXIBLE, flexDefaultPenalty); | |
| penaltyBuilder.with(StreetMode.FLEXIBLE, flexDefaultPenalty); |
optionsome
reviewed
Dec 12, 2024
| "accessEgress: AccessEgressPreferences{penalty: TimeAndCostPenaltyForEnum{CAR_TO_PARK: " + | ||
| "accessEgress: AccessEgressPreferences{penalty: TimeAndCostPenaltyForEnum{" + | ||
| "CAR: (timePenalty: 20m + 2.0 t, costFactor: 1.50), " + | ||
| "CAR_TO_PARK: " + | ||
| CAR_PENALTY + |
There was a problem hiding this comment.
The name of this variable is a bit misleading since it's only used for CAR_TO_PARK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The CAR & CAR_PICKUP can be used in access/egress, but no default time-penalty was set.
We need to clearify if tipe-penalty should apply to CAR!
Issue
🟥 There is not issue for this. This is just a something we forgot to do. All CAR modes that can be used as access/egress should have a time-penalty, maybe except CAR.
Unit tests
✅ Unit tests are updated.
Documentation
✅ Unit tests are updated.
Changelog
✅ The bug exist in 2.6
Bumping the serialization version id
🟥 Not needed