fix exception loading pickup / drop off for a leg if the stop is skipped in GTFS GraphQL API

[miklcct]

Summary

Fix exception loading pickup / drop off for a leg if the stop is skipped. It attempts to directly map the internal PickDrop name into the API but the API doesn't have a value for cancelled (which it uses null for the purpose).

Issue

Fixes #6290

Unit tests

TBD

Documentation

None, bug fix only.

Changelog

[leonardehrenfried]

It's being fixed over at https://github.com/opentripplanner/OpenTripPlanner/pull/5393/files#diff-0ece060ada3613c2e1e70314338aea469811985e56ace731edfa2aa0ed7d677b

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 69.78%. Comparing base (684b841) to head (72e739f).
Report is 1 commits behind head on dev-2.x.

Files with missing lines	Patch %	Lines
...pentripplanner/apis/gtfs/datafetchers/LegImpl.java	0.00%	10 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             dev-2.x    #6291      +/-   ##
=============================================
- Coverage      69.79%   69.78%   -0.01%     
+ Complexity     17786    17784       -2     
=============================================
  Files           2017     2017              
  Lines          76042    76048       +6     
  Branches        7781     7785       +4     
=============================================
- Hits           53073    53071       -2     
- Misses         20264    20271       +7     
- Partials        2705     2706       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[miklcct]

Ok I'll leave this as a draft then and won't publish it, and wait until #5393 is merged. I just need this as an urgent fix to my deployment to tell the user that your train will now skip your stop.