Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refetching transit leg will not work if an additional call is added into the leg real-time #6301

Open
miklcct opened this issue Dec 3, 2024 · 0 comments

Comments

@miklcct
Copy link
Contributor

miklcct commented Dec 3, 2024

Expected behavior

The leg can be refetched

Observed behavior

The refetch leg call returns null

Version of OTP used (exact commit hash or JAR name)

2.7.0-SNAPSHOT

Data sets in use (links to GTFS and OSM PBF files)

Any GTFS feed with replacement trips adding station calls in GTFS-RT update.

Steps to reproduce the problem

  1. Get an itinerary with leg IDs
  2. Add an extra call into one of the legs by means of a replacement trip in GTFS-RT
  3. Refetch the leg.

It returns null because the stop position in pattern has changed, so ScheduledTransitLegReference can't match it.

I think that for post OTP-2.5, it should fall back to using stops (including other platforms in the same station) to refetch the leg if the stop position doesn't match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant