Codecov Report

Attention: Patch coverage is 37.34177% with 99 lines in your changes missing coverage. Please review.

Project coverage is 69.77%. Comparing base (cd254bf) to head (defdf5f).
Report is 29 commits behind head on dev-2.x.

@@              Coverage Diff              @@
##             dev-2.x    #6284      +/-   ##
=============================================
- Coverage      69.81%   69.77%   -0.05%     
- Complexity     17825    17841      +16     
=============================================
  Files           2020     2028       +8     
  Lines          76271    76384     +113     
  Branches        7806     7806              
=============================================
+ Hits           53250    53298      +48     
- Misses         20304    20370      +66     
+ Partials        2717     2716       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@habrahamsson-skanetrafiken Can I ask you to review this one? If not let me know and I will reassign.

It never occurred to me until yesterday's meeting that I also could have made the current updater/loader configurable. Let me know if you feel that's the better option, @t2gran.

Here is what I had in mind with respect to manual Dependency Injection:

package org.opentripplanner.updater.siri.configure;

/** This is doing manually dependency injection and work as a factory to create the updater components. */
class SiriUpdaterModule {

   public static SiriETUpdater createSiriETUpdater(...) {
     var loader = createLoader(...);    
     var source = createSource(loader, ...);
     return createETUpdater(source, ...);
   }

  private static createLoader(...);    
  private static createSource(...);
  private static createUpdater(...);
}

Each component define the parameters as an interface inside the class. The same parameters can be repeated, but not inherited. For example if URI uri() is used in Loader and Updater both interfaces have the same method. Then the implementation of these 3 interfaces can be passed to all 3, but each class only see the set of parameters they need. If the main class (Updator) inherit an other class and that has a Parameters inside, then the main parameter will inherit that. In other words, the Parameters classes follow the same inheritance structure as the outer main class.
A extends B ==> A.Parameters extends B.Parameters.

The factory for creating the Loader can be inlined here. The SiriUpdaterModule reduce the dependencies and remove DI code from the Updaters constructors.

@t2gran I have introduce the DI class that you requested in defdf5f