Codecov Report

Attention: Patch coverage is 84.09091% with 7 lines in your changes missing coverage. Please review.

Project coverage is 69.80%. Comparing base (684b841) to head (e09e5ba).
Report is 1 commits behind head on dev-2.x.

@@            Coverage Diff             @@
##             dev-2.x    #6280   +/-   ##
==========================================
  Coverage      69.79%   69.80%           
- Complexity     17786    17798   +12     
==========================================
  Files           2017     2017           
  Lines          76042    76081   +39     
  Branches        7781     7789    +8     
==========================================
+ Hits           53073    53106   +33     
  Misses         20264    20264           
- Partials        2705     2711    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sorry it seems that the bug still appears on the live server, so I need to mark this as draft for now.

The solution will not work if a timetable is cleared multiple times between commits. Also on my live server log there are a lot of "WARN could not fetch timetable for pattern" which may be related to this problem as well. I'll need to further fix it.

What does this line actually mean:

My server log is flooded with this.

Would it work and would it be simpler if:

1. We set a flag in the TransitLayerUpdater each time we call TimetableSnapshot.clear():

public clear(String feedId) {
...
if(transitLayerUpdater != null) {
transitLayerUpdater.setCleared(feedId);
}
}

2. The TransitLayerUpdater checks the flag and clears all data belonging to this feed before applying the updates:

public void update(
    Collection<Timetable> updatedTimetables,
    Map<TripPattern, SortedSet<Timetable>> timetables
  ) {
if(isCleared(feedId)) {
realtimeTransitLayer.clear(feedId);
setCleared(feedId, false);
}
// apply updates
}

Would it work and would it be simpler if:

1. We set a flag in the TransitLayerUpdater each time we call TimetableSnapshot.clear():

public clear(String feedId) {
...
if(transitLayerUpdater != null) {
transitLayerUpdater.setCleared(feedId);
}
}

2. The TransitLayerUpdater checks the flag and clears all data belonging to this feed before applying the updates:

public void update(
    Collection<Timetable> updatedTimetables,
    Map<TripPattern, SortedSet<Timetable>> timetables
  ) {
if(isCleared(feedId)) {
realtimeTransitLayer.clear(feedId);
setCleared(feedId, false);
}
// apply updates
}

I think it will be better and I will work on this.

Unfortunately TransitLayerUpdater is not feed aware and it doesn't really have a state, so it is not possible for me to do that without adding complexity into the system. There is no concept of a "feed" and the "original" in the TransitLayer.