Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stress-test] Network Formation Test failing with excessively high timing values #273

Closed
Vinggui opened this issue May 8, 2022 · 4 comments · Fixed by #274
Closed

[Stress-test] Network Formation Test failing with excessively high timing values #273

Vinggui opened this issue May 8, 2022 · 4 comments · Fixed by #274

Comments

@Vinggui
Copy link
Contributor

Vinggui commented May 8, 2022

I recently submitted a PR 235 which passed everything, but part of the stress-test. Here is the final result:

2022-05-07T20:13:09.8148475Z 	7x7 average formation time 5242.137931034483 > 200
2022-05-07T20:13:09.8149052Z | 2x2 | 5s | 4s | 4s | 4s | 5s | 5s | 5s | 4s | 4s | 4s | 4s | 6s | 4s | 4s | 4s | 5s | 4s | 4s | 5s | 4s | 4s | 4s | 4s | 5s | 4s | 5s | 5s | 4s | 4s | 4s |
2022-05-07T20:13:09.8149418Z | 3x3 | 8s | 6s | 6s | 6s | 6s | 6s | 6s | 5s | 8s | 7s | 6s | 8s | 6s | 6s | 6s | 6s | 6s | 6s | 5s | 7s | 4s | 6s | 6s | 5s | 6s | 6s | 6s | 6s | 7s | 6s |
2022-05-07T20:13:09.8149787Z | 4x4 | 6s | 7s | 8s | 8s | 8s | 8s | 8s | 8s | 7s | 10s | 8s | 8s | 8s | 8s | 7s | 7s | 7s | 6s | 6s | 7s | 9s | 8s | 8s | 9s | 8s | 8s | 8s | 6s | 7s | 8s |
2022-05-07T20:13:09.8150233Z | 5x5 | 12s | 133s | 8s | 9s | 9s | 10s | 12s | 8s | 7s | 12s | 7s | 12s | 8s | 10s | 11s | 14s | 15s | 10s | 9s | 9s | 133s | 13s | 13s | 11s | 8s | 7s | 10s | 13s | 11s | 8s |
2022-05-07T20:13:09.8150618Z | 6x6 | 15s | 18s | 9s | 15s | 11s | 16s | 18s | 16s | 15s | 135s | 13s | 17s | 10s | 14s | 22s | 20s | 12s | 9s | 132s | 16s | 607s | 18s | 16s | 14s | 11s | 20s | 14s | 9s | 15s | 11s |
2022-05-07T20:13:09.8151007Z | 7x7 | 19s | 18s | 11s | 24676s | 16s | 19s | 20s | 20s | 22s | 16s | 20s | 15s | 21s | 15s | 264135s | 18s | 21s | 19s | 125833s | 15s | 14s | 250s | 21s | 18s | 17s | 15s | 136s | 134s | 584s | 19s |
2022-05-07T20:13:09.8250382Z ##[error]Process completed with exit code 1.

Maybe it is something that I coded that caused this problem, but PR 270 failed pretty much the same way. I wonder if there is some part of the code that causes this intermittent timings.
@simonlingoogle
Copy link
Member

@Vinggui Thanks for reporting this issue.

It's a duplicate of openthread/openthread#7674

The cause has been identified.

@Vinggui
Copy link
Contributor Author

Vinggui commented May 8, 2022

Thanks!

@Vinggui Vinggui closed this as completed May 8, 2022
@simonlingoogle simonlingoogle mentioned this issue May 8, 2022
Merged
@simonlingoogle
Copy link
Member

@Vinggui #274 should fix this issue.
Please take a look, thanks.

@Vinggui
Copy link
Contributor Author

Vinggui commented May 8, 2022

I saw that now. Great work identifying it.

@Vinggui Vinggui changed the title [Stress-test] Network Formation Test failing with excessively high timings values [Stress-test] Network Formation Test failing with excessively high timing values May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[stress-tests] remove 7x7 topology from network_forming.py simonlingoogle/ot-ns
2 participants
@Vinggui @simonlingoogle