Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate the style has configurable options in the installer #1150

Closed
pep0w opened this issue Dec 28, 2020 · 7 comments · Fixed by #1302
Closed

Indicate the style has configurable options in the installer #1150

pep0w opened this issue Dec 28, 2020 · 7 comments · Fixed by #1302

Comments

@pep0w
Copy link

pep0w commented Dec 28, 2020

Is there a way to install styles from greasyfork that have customizable options?
So far my tests have shown it's not possible, and I might have to switch to xStyle.
If it's not supported yet, can we get an eta (if any) on when support would be added?

@tophf
Copy link
Member

tophf commented Dec 29, 2020

Stylus provides a built-in config UI for any UserCSS style regardless of the site from which it's installed.

Without seeing the style in question I can only guess it's not correct.
See https://github.com/openstyles/stylus/wiki/Writing-UserCSS

@tophf tophf closed this as completed Dec 29, 2020
@pep0w
Copy link
Author

pep0w commented Dec 29, 2020

@tophf
Well then, I didn't realize that it doesn't show the options before installing.
This is kind of counter intuitive.
The advanced options should be shown on the install page so it's easier and quicker to customize.
My format is the uso format btw. I saved the styles with xstyle, since it has the same editing layout as uso, so it was much simpler to do some edits on them before I just exported and copied to greasyfork.

@tophf
Copy link
Member

tophf commented Dec 29, 2020

You can suggest greasyfork to implement a UI for the options. We won't be modifying the page of an external site, of course.

As for showing the config in the installer UI, that won't work because the style should be installed for the options to have effect.

We could show the config after the style is installed, of course, but I'm not sure that's really necessary as we offer arguably better ways to invoke the config UI - right in the popup so you can customize the style while viewing the changes live inside the current tab.

What we can do is show an initially disabled "Configure" button inside the installer page, with a tooltip that the style should be installed first, because there are probably a lot of people who only used userstyles.org site with its config UI prior to installation. The tooltip should also probably mention that there's a better way to do it via the popup.

@tophf tophf reopened this Dec 29, 2020
@tophf tophf changed the title Installing userstyles with customizable options from Greasyfork Indicate the style has configurable options in the installer Dec 29, 2020
@pep0w
Copy link
Author

pep0w commented Dec 29, 2020

When I click install as user css on greasyfork, stylus opens a new install page, the settings should be shown there instead of afterwards...

@tophf
Copy link
Member

tophf commented Dec 29, 2020

AFAIK you're the first one who thinks that so no, they shouldn't. Normally people don't bother with settings. Those who do will open the site, see something they don't like and then click the popup to configure the style in live mode with their choices instantly applied to the site so they don't have to switch tabs or guess the outcome. My comment above shows what we can do about this "problem".

@eight04
Copy link
Collaborator

eight04 commented Dec 30, 2020

So far my tests have shown it's not possible

Could you elaborate what kinds of tests have you done? Maybe we just have to display the configuration UI in edit.html.

Tampermonkey also displays script settings along with the editor:
image

show an initially disabled "Configure" button inside the installer page

I thought we redirect users to the editor after the installation. Do you mean to add the button to the editor?

@tophf
Copy link
Member

tophf commented Dec 30, 2020

we redirect users to the editor

If live edit is not enabled, yes. I forgot about that. So indeed we'll either show the button in both the editor and the installer or it'll be a short tooltip with (i) that explains the popup feature in more detail.

Tampermonkey also displays script settings along with the editor:

Those are not script variables though. It's more of #827.

Maybe we just have to display the configuration UI in edit.html.

And what usage scenario will that improve? We already have better methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants