-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indicate the style has configurable options in the installer #1150
Comments
Stylus provides a built-in config UI for any UserCSS style regardless of the site from which it's installed. Without seeing the style in question I can only guess it's not correct. |
@tophf |
You can suggest greasyfork to implement a UI for the options. We won't be modifying the page of an external site, of course. As for showing the config in the installer UI, that won't work because the style should be installed for the options to have effect. We could show the config after the style is installed, of course, but I'm not sure that's really necessary as we offer arguably better ways to invoke the config UI - right in the popup so you can customize the style while viewing the changes live inside the current tab. What we can do is show an initially disabled "Configure" button inside the installer page, with a tooltip that the style should be installed first, because there are probably a lot of people who only used userstyles.org site with its config UI prior to installation. The tooltip should also probably mention that there's a better way to do it via the popup. |
When I click install as user css on greasyfork, stylus opens a new install page, the settings should be shown there instead of afterwards... |
AFAIK you're the first one who thinks that so no, they shouldn't. Normally people don't bother with settings. Those who do will open the site, see something they don't like and then click the popup to configure the style in live mode with their choices instantly applied to the site so they don't have to switch tabs or guess the outcome. My comment above shows what we can do about this "problem". |
If live edit is not enabled, yes. I forgot about that. So indeed we'll either show the button in both the editor and the installer or it'll be a short tooltip with
Those are not script variables though. It's more of #827.
And what usage scenario will that improve? We already have better methods. |
Is there a way to install styles from greasyfork that have customizable options?
So far my tests have shown it's not possible, and I might have to switch to xStyle.
If it's not supported yet, can we get an eta (if any) on when support would be added?
The text was updated successfully, but these errors were encountered: