Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: outdated caniuse-lite #2336

Closed
wants to merge 2 commits into from
Closed

fix: outdated caniuse-lite #2336

wants to merge 2 commits into from

Conversation

hamirmahal
Copy link

fixes #2335.

@hamirmahal hamirmahal requested a review from a team as a code owner August 23, 2024 23:13
@hamirmahal hamirmahal requested a review from RoyEJohnson August 23, 2024 23:13
Copy link
Member

@TomWoodward TomWoodward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hamirmahal thank you for the PR! I appreciate it, but unfortunately something about this change seems to be breaking the node/babel-register config that is used for the static site rendering part of the app, so it doesn't seem like this is going to be as simple as it looks.

CI still fails.

This reverts commit 9bf7039.
@TomWoodward
Copy link
Member

closing due to inactivity. the check did pass again after reverting the update. looks like more work would be needed to make this change.

@TomWoodward TomWoodward closed this Sep 9, 2024
@hamirmahal hamirmahal deleted the fix/outdated-caniuse-lite branch September 9, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browserslist: caniuse-lite is outdated.
2 participants