Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we have some github action checks in this repository? #4

Open
levitte opened this issue Apr 13, 2023 · 0 comments
Open

Should we have some github action checks in this repository? #4

levitte opened this issue Apr 13, 2023 · 0 comments

Comments

@levitte
Copy link
Member

levitte commented Apr 13, 2023

This follows #3. To be able to fix bugs discovered by new before it hits openssl/openssl, a test build + run should be made in PRs done here. I really can't imagine it being very hard, if you consider running the related OpenSSL test recipes with a corpora that's not in the OpenSSL source tree. This patch in OpenSSL should help:

diff --git a/test/recipes/fuzz.pl b/test/recipes/fuzz.pl
index 3f03eef4f7..549970d137 100644
--- a/test/recipes/fuzz.pl
+++ b/test/recipes/fuzz.pl
@@ -8,6 +8,7 @@
 use strict;
 use warnings;
 
+use File::Spec;
 use OpenSSL::Glob;
 use OpenSSL::Test qw/:DEFAULT srctop_dir/;
 
@@ -15,7 +16,8 @@ sub fuzz_ok {
     die "Only one argument accepted" if scalar @_ != 1;
 
     my $f = $_[0];
-    my $d = srctop_dir('fuzz', 'corpora', $f);
+    my $d = ENV{FUZZ_CORPORA} // srctop_dir('fuzz', 'corpora');
+    $d = File::Spec->catdir($d, $f);
 
     SKIP: {
         skip "No directory $d", 1 unless -d $d;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant