Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox will (probably) not be able to log in at next release #111

Open
sigurdne opened this issue Aug 30, 2018 · 2 comments
Open

Firefox will (probably) not be able to log in at next release #111

sigurdne opened this issue Aug 30, 2018 · 2 comments

Comments

@sigurdne
Copy link

sigurdne commented Aug 30, 2018

Hi

Made an attempt at Version: 1.5.103-SNAPSHOT in eclipse:
This commit on Jun 12 seems to break the index/login-page when using Firefox
9a0fb16

Firefox version 61.0.1

Regards

@sigurdne
Copy link
Author

I am struggling with finding the exact code change that caused Firefox to complain.
I followed the instructions for eclipse
https://github.com/opensourceBIM/BIMserver/wiki/Eclipse
And rolled back changes to may 2018 for:

  • bimvie.ws
  • BIMserver-JavaScript-API
  • BIMserver

But still Firefox is complaining as follows:

SyntaxError: import declarations may only appear at top level of a module

Regards

@rubendel
Copy link
Member

At the moment we only develop/test on Google Chrome. So that's also the only platform supported. Any fixes that make BIMvie.ws work on other platforms are always welcome.

The problem here is that we don't know in advance where the API is coming from (it's dynamic), but Firefox does not like this, I think they will change this in the future as this is not a unique problem. Also when dynamic loading of modules has been standardized, we can switch to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants