Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework settings and update to IfcOpenShell v0.8 #17

Open
hlg opened this issue Sep 16, 2024 · 2 comments
Open

Rework settings and update to IfcOpenShell v0.8 #17

hlg opened this issue Sep 16, 2024 · 2 comments

Comments

@hlg
Copy link
Member

hlg commented Sep 16, 2024

There have been changes to the way how IfcOpenShell handles settings from v0.8 on. The rework might also consider new settings such as "permissive extrusions" (allows extrusions depths of zero or less). Parallel adjustments might need to be made on the geometry server side in IfcOpenShell itself.

See IfcOpenShell/IfcOpenShell#1490 (comment) for reference.

Maybe the settings could also be handled dynamically, but then it needs some thought how compatibilty between versions is going to be handled and how settings should be maintained in the BIMserver database while allowing for the IfcOpenShell version to be switched.

@hlg
Copy link
Member Author

hlg commented Sep 18, 2024

There have been changes already from v0.6.0 to v0.7.0.

In v0.6.0 we have setting IDs as follows:

SEW_SHELLS = 1 << 4,
DISABLE_OPENING_SUBTRACTIONS = 1 << 6,
APPLY_LAYERSETS = 1 << 13,

In v0.7.0 due to the removal of the FASTER_BOOLEAN setting, there is:

SEW_SHELLS = 1 << 4,
DISABLE_OPENING_SUBTRACTIONS = 1 << 5,
APPLY_LAYERSETS = 1 << 12,

Even though I don't know if this accounts for all 0.7.0 builds, to handle this change, we can only make a distinction on the basis of the version that the geom server announces during the HELLO handshake. It may be that some earlier 0.7.0 builds will fail with this, but the later ones should work. It is a pity that there is no semantic versioning on the minor number. Commit SHAs are not consecutive, we would have to enumerate the SHAs of the builds in order to distinguish the builds before and after the FASTER_BOOLEAN removal.

hlg added a commit to hlg/IfcOpenShell-BIMserver-plugin that referenced this issue Sep 18, 2024
@aothms
Copy link
Member

aothms commented Sep 18, 2024

Yeah... sorry bout that. In 0.8 settings are identified by string so wouldn't affect us like that anymore in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants