created jenkinsfile refer to @master of library files

[maxandersen]

generated projects refer to @Library('github.com/fabric8io/fabric8-pipeline-library@master') rather than a specific version.

I would have expected a specific version or possibly a branch where only minor issues would be changing ?

[joshuawilson]

This issue was moved to fabric8-ui/fabric8-ui#1365

[maxandersen]

This issue still happens; just 2018-01-09 created a project in prod-preview and the same @master reference is inserted (see https://github.com/maxandersen/tonightshow2/blob/master/Jenkinsfile#L2)

The linked issue seem to just been closed without no update/context thus keeping this open.

[maxandersen]

p.s. pointing to @master wouldn't be an issue if we could guarantee at least some certainty the library would be backwards/forwards compatible in perpetuity.

[piyush-garg]

@maxandersen Is this you think need to be resolved? We are going well with master branch 😃

[maxandersen]

is the head of master branch still able to build/run project created 6 months ago ?

How about 12 months from now ? will master be able to build/run projects made today ?

[sthaha]

I am turning this into a feature request for the pipeline-library since what I gather from the issue is that it is asking the library to follow some consistent versioning system like semver.

[rupalibehera]

This looks like a feature request

[bartoszmajsak]

This requires a bit of automation too. All the jenkinsfiles are sourced from this repo https://github.com/fabric8io/fabric8-jenkinsfile-library, so whenever we have a new version and know it works (testing? ;)) - we should trigger update to this repo accordingly.

[lordofthejars]

@bartoszmajsak I have seen that all these things are already done, see https://github.com/fabric8io/fabric8-pipeline-library/blob/master/release.groovy#L19 so the question is if it has ever used (my bets are that it is since there are a lot of tags on repo). So the real question is why this was not used since 2017?

@sthaha @piyush1594 @rupalibehera @kishansagathiya Do you know anything about this? If there is still a job created for this somewhere?

[kishansagathiya]

@bartoszmajsak

so whenever we have a new version and know it works (testing? ;)) - we should trigger update to this repo accordingly.

Why is this required? I am under and impression that with a project we use a pipeline library version that is compatible with it. So, a project that was created 6 months ago would be creating a pipeline library version that was released six months ago.
If we do this, below question would be answered in yes

is the head of master branch still able to build/run project created 6 months ago ?

Isn't changing the project with the new pipeline version like using master?

[kishansagathiya]

@lordofthejars

Do you know anything about this? If there is still a job created for this somewhere?

Nope

[lordofthejars]

I have been testing how to automate the release of Jenkins Pipeline as well as updating the Jenkinsfile. I have cloned these repos at my github account and I have configured a job in Jenkins (https://jenkins.cd.test.fabric8.io/job/flp-lordofthejars/4/) and it worked well updating everything. Then when you run in the fabric8 job (https://jenkins.cd.test.fabric8.io/job/fabric8io/job/fabric8-pipeline-library/job/master/3/console) you get a failure on host key verification:

git push origin v2.2.335
Host key verification failed.
fatal: Could not read from remote repository.

So almost there, all the automation is done, currently, there is no trigger that fires this job, which means that we need to manually push the play button, but I think that since this job modifies downstream project, I think it is the best way for now.

[bartoszmajsak]

Why is this required? I am under and impression that with a project we use a pipeline library version that is compatible with it. So, a project that was created 6 months ago would be creating a pipeline library version that was released six months ago.

@kishansagathiya not sure if we are talking about the same thing so let me rephrase.

When you create new project (or import to OSIO) we get Jenkinsfiles from the https://github.com/fabric8io/fabric8-jenkinsfile-library - they are all pointing to master https://github.com/fabric8io/fabric8-pipeline-library. If we start making "releases" those files should be updated accordingly, otherwise we don't fix anything from OSIO standpoint.

[chmouel]

This is going to be addressed with osio-pipeline library as we plan to do versionning properly there,

can you confirm @sthaha or @hrishin and closes this year and half old issue if that's correct,

[hrishin]

Yes @chmouel that's the plan with osio-pipeline library.
fabric8io/osio-pipeline#77

[chmouel]

perfect closed ;)