Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding kola test to check for Butane spec stabilization #1336

Open
bgilbert opened this issue Jul 21, 2023 · 0 comments
Open

Consider adding kola test to check for Butane spec stabilization #1336

bgilbert opened this issue Jul 21, 2023 · 0 comments
Labels
jira lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@bgilbert
Copy link
Contributor

Currently we don't have anything that ensures we stabilize a Butane openshift spec every OCP release cycle. Per discussion with @dustymabe, we could add a test so we don't forget to do this.

Butane is invoked by users, not by tools, and the user also selects the spec to be used. Also, Butane isn't in the OS or the release payload, nor does it have a downstream container image. As a result, figuring out what to check isn't completely trivial.

Proposal:

  1. Compute the OCP version from the RHCOS version.
  2. Generate an openshift Butane config with a non-experimental version matching the OCP version.
  3. Download the latest Butane from the mirror.
  4. See if the config transpiles. In Git master, it probably never will, assuming RHCOS is branched before Butane stabilizes the new spec. But in the release branch, it eventually will, late in the OCP development cycle.
  5. Use a snooze to disable the test until after the expected spec stabilization date. When tests fail on master, bump the snooze. When they fail on the branch, there's an actual problem.

This is all a bit awkward, though, since it would fail RHCOS builds solely to draw attention to an unrelated problem.

@bgilbert bgilbert added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jul 21, 2023
@dustymabe dustymabe added the jira label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

2 participants