Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s390x/Secure Execution: Firstboot fails during ignition-ostree-growfs.service #1264

Closed
jschintag opened this issue Apr 18, 2023 · 7 comments · Fixed by coreos/fedora-coreos-config#2383
Closed

s390x/Secure Execution: Firstboot fails during ignition-ostree-growfs.service #1264

jschintag opened this issue Apr 18, 2023 · 7 comments · Fixed by coreos/fedora-coreos-config#2383
Assignees
@jlebon
Labels
jira

Comments

@jschintag
Copy link
Contributor

The Secure Execution is unable to boot, failing at ignition-ostree-growfs.service.

Displaying logs from failed units: ignition-ostree-growfs.service
Apr 18 08:42:09 systemd[1]: Starting Ignition OSTree: Grow Root Filesystem...
Apr 18 08:42:09 ignition-ostree-growfs[2448]: mount: /sysroot: special device /dev/disk/by-label/root does not exist.
Apr 18 08:42:09 systemd[1]: ignition-ostree-growfs.service: Main process exited, code=exited, status=32/n/a
Apr 18 08:42:09 systemd[1]: ignition-ostree-growfs.service: Failed with result 'exit-code'.
Apr 18 08:42:09 systemd[1]: Failed to start Ignition OSTree: Grow Root Filesystem.

Generating "/run/initramfs/rdsosreport.txt"

This just started with 414.92.202304172216-0, the build before is working. Looking at the diff, there are no relevant package diffs. The only notable difference between the builds is the f-c-c bump.
Need to investigate further.
@jschintag
Copy link
Contributor Author

Issue seems to have been introduced by this PR coreos/fedora-coreos-config#2320

@jlebon
Copy link
Member

jlebon commented Apr 18, 2023

Will dig into this.

@jlebon jlebon self-assigned this Apr 18, 2023
@jlebon jlebon added the jira label Apr 18, 2023
@jschintag
Copy link
Contributor Author

I think it might be timing related, because in the emergency console the device label exists

@jschintag
Copy link
Contributor Author

I just finished testing it and a simple Require=/dev/disk/by-label/root in the ignition-ostree-growfs.service seems to fix it. I will post a PR

jschintag added a commit to jschintag/fedora-coreos-config that referenced this issue Apr 18, 2023
@jschintag
40ignition-ostree/ignition-ostree-growfs.service: Wait for root devic…
0c62166 
…e to be present

There seems to be a simple race condition. Ensure the rootfs disk is present
before running the service.

Fixes: openshift/os#1264

Signed-off-by: Jan Schintag <[email protected]>
@jschintag
Copy link
Contributor Author

Ok, while it does seem to help, i still run into the problem. It might just have taken down the error rate from 100% to ~50%

@jschintag jschintag mentioned this issue Apr 18, 2023
Merged
jschintag added a commit to jschintag/fedora-coreos-config that referenced this issue Apr 18, 2023
@jschintag
40ignition-ostree/ignition-ostree-growfs: Fix Secure Execution firstb…
22477f2 
…oot error

Ensure that /dev/disk/by-label/root is present before running service.
Do not try to mount disk when running in Secure Execution mode.

Fixes: openshift/os#1264

Signed-off-by: Jan Schintag <[email protected]>
jschintag added a commit to jschintag/fedora-coreos-config that referenced this issue Apr 19, 2023
@jschintag
40ignition-ostree/ignition-ostree-growfs: Fix Secure Execution firstb…
739a484 
…oot error

Ensure that /dev/disk/by-label/root is present before running service.
Do not try to mount disk when running in Secure Execution mode.

Fixes: openshift/os#1264

Signed-off-by: Jan Schintag <[email protected]>
jlebon pushed a commit to jschintag/fedora-coreos-config that referenced this issue Apr 19, 2023
@jschintag @jlebon
40ignition-ostree/ignition-ostree-growfs: Fix Secure Execution firstb…
654e4c3 
…oot error

Do not try to mount disk when running in Secure Execution mode.

Fixes: openshift/os#1264

Signed-off-by: Jan Schintag <[email protected]>
jlebon pushed a commit to coreos/fedora-coreos-config that referenced this issue Apr 19, 2023
@jschintag @jlebon
40ignition-ostree/ignition-ostree-growfs: Fix Secure Execution firstb…
9f6a655 
…oot error

Do not try to mount disk when running in Secure Execution mode.

Fixes: openshift/os#1264

Signed-off-by: Jan Schintag <[email protected]>
@jschintag
Copy link
Contributor Author

Waiting on #1268 to pull the fix into RHCOS

@jschintag
Copy link
Contributor Author

Bump has landed and latest nightly is working correctly.

c4rt0 pushed a commit to c4rt0/fedora-coreos-config that referenced this issue May 17, 2023
@jschintag @c4rt0
40ignition-ostree/ignition-ostree-growfs: Fix Secure Execution firstb…
5894783 
…oot error

Do not try to mount disk when running in Secure Execution mode.

Fixes: openshift/os#1264

Signed-off-by: Jan Schintag <[email protected]>
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@jschintag @HuijingHei
40ignition-ostree/ignition-ostree-growfs: Fix Secure Execution firstb…
25a4c25 
…oot error

Do not try to mount disk when running in Secure Execution mode.

Fixes: openshift/os#1264

Signed-off-by: Jan Schintag <[email protected]>
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
@jschintag @HuijingHei
40ignition-ostree/ignition-ostree-growfs: Fix Secure Execution firstb…
da55483 
…oot error

Do not try to mount disk when running in Secure Execution mode.

Fixes: openshift/os#1264

Signed-off-by: Jan Schintag <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlebon jlebon

Labels
jira
Projects
None yet
Milestone
No milestone
2 participants
@jlebon @jschintag