Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dan and George from OWNERS #837

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

geowa4
Copy link

@geowa4 geowa4 commented Nov 19, 2024

Dan and I are managers now on ARO and no longer need or should have ownership.

Dan and I are managers now on ARO and no longer need or should have
ownership.
@dkeohane
Copy link
Member

o7

Copy link
Contributor

openshift-ci bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: geowa4
Once this PR has been reviewed and has the lgtm label, please assign bergmannf for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geowa4
Copy link
Author

geowa4 commented Nov 19, 2024

/retest

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.04%. Comparing base (4c2872b) to head (e2897be).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #837   +/-   ##
=======================================
  Coverage   47.04%   47.04%           
=======================================
  Files          45       45           
  Lines        6723     6723           
=======================================
  Hits         3163     3163           
  Misses       3229     3229           
  Partials      331      331           
---- 🚨 Try these New Features:

@geowa4
Copy link
Author

geowa4 commented Nov 21, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

@geowa4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate e2897be link true /test validate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants