Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable openshift-kubernetes-nmstate-operator in konflux #5722

Conversation

joepvd
Copy link
Contributor

@joepvd joepvd commented Nov 22, 2024

No description provided.

Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from joepvd. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

Validating 1 file(s)...
Validating images/openshift-kubernetes-nmstate-operator.yml...
Traceback (most recent call last):
File "/usr/local/bin/validate-ocp-build-data", line 33, in
sys.exit(load_entry_point('rh-ocp-build-data-validator==0.2.5', 'console_scripts', 'validate-ocp-build-data')())
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 87, in main
validate(f, args.exclude_vpn, args.schema_only)
File "/usr/local/lib/python3.9/site-packages/validator/main.py", line 23, in validate
support.fail_validation(msg, parsed)
File "/usr/local/lib/python3.9/site-packages/validator/support.py", line 14, in fail_validation
raise exceptions.ValidationFailed(msg)
validator.exceptions.ValidationFailed: Schema mismatch: images/openshift-kubernetes-nmstate-operator.yml
Returned error: Additional properties are not allowed ('konflux', 'delivery' were unexpected)

@locriandev
Copy link

/hold
While this works, I am working on a change in art-tools that will let us not crash the pipeline on rebase failures. Instead, we should continue building what we can

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2024
@joepvd
Copy link
Contributor Author

joepvd commented Nov 22, 2024

/close
locriandev has the proper approach in the works 👍🏼

@openshift-ci openshift-ci bot closed this Nov 22, 2024
Copy link
Contributor

openshift-ci bot commented Nov 22, 2024

@joepvd: Closed this PR.

In response to this:

/close
Daniele has the proper approach in the works 👍🏼

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants