Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Ensure that all common.Runnables have implemented the required methods #55

Open
johnsonshi opened this issue Aug 5, 2021 · 1 comment
Labels
good first issue Good for newcomers

Comments

@johnsonshi
Copy link
Contributor

The common.Runnable interface requires several methods to be implemented. This issue has a few parts:
(1) Ensure that all required methods are implemented (example: implement the methods at

// Suggestion implements common.Runnable
func (check EnvoySidecarImageCheck) Suggestion() string {
panic("implement me")
}
// FixIt implements common.Runnable
func (check EnvoySidecarImageCheck) FixIt() error {
panic("implement me")
}
)
(2) Ensure that common.Runnable outcomes structs contain the newly implemented Suggestions() and FixIt()
err := check.Run()
outcomes[idx] = Outcome{
RunnableInfo: check.Info(),
Error: err,
}

(3) Ensure that suggestions and fixit are printed here: https://github.com/openservicemesh/osm-health/blob/main/pkg/common/printer.go

@johnsonshi johnsonshi added the good first issue Good for newcomers label Aug 5, 2021
@SanyaKochhar SanyaKochhar self-assigned this Sep 9, 2021
@SanyaKochhar
Copy link
Contributor

SanyaKochhar commented Sep 9, 2021

Part 1 (method implementation) has been checked. Can revisit 2 once 3 is completed.

@SanyaKochhar SanyaKochhar removed their assignment Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants