func PodToPod() in pkg/connectivity/pod-to-pod.go should return error

[johnsonshi]

The function should return an error. Specifically referring to

osm-health/pkg/connectivity/pod-to-pod.go

Lines 14 to 16 in fae1393

	// PodToPod tests the connectivity between a source and destination pods.
	func PodToPod(fromPod *v1.Pod, toPod *v1.Pod) {
	log.Info().Msgf("Testing connectivity from %s/%s to %s/%s", fromPod.Namespace, fromPod.Name, toPod.Namespace, toPod.Name)

There are several points in this function where continuing execution would probably not make sense?

osm-health/pkg/connectivity/pod-to-pod.go

Lines 22 to 25 in fae1393

	client, err := kuberneteshelper.GetKubeClient()
	if err != nil {
	log.Err(err).Msg("Error creating Kubernetes client")
	}

osm-health/pkg/connectivity/pod-to-pod.go

Lines 29 to 32 in fae1393

	srcConfigGetter, err = envoy.GetEnvoyConfigGetterForPod(fromPod, osmVersion)
	if err != nil {
	log.Err(err).Msgf("Error creating ConfigGetter for pod %s/%s", fromPod.Namespace, fromPod.Name)
	}

osm-health/pkg/connectivity/pod-to-pod.go

Lines 34 to 37 in fae1393

	dstConfigGetter, err = envoy.GetEnvoyConfigGetterForPod(toPod, osmVersion)
	if err != nil {
	log.Err(err).Msgf("Error creating ConfigGetter for pod %s/%s", toPod.Namespace, toPod.Name)
	}

Creating this issue to kick off discussion about this.