Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/Consolidate views templates: Move common formatting functions to helpers #67

Closed
Mandalka opened this issue Oct 4, 2019 · 4 comments
Closed

Refactor/Consolidate views templates: Move common formatting functions to helpers #67

Mandalka opened this issue Oct 4, 2019 · 4 comments
Assignees
@Mandalka
Labels
enhancement

Comments

@Mandalka
Copy link
Collaborator

Mandalka commented Oct 4, 2019

Move formatting functions like generation of URL labels which are the same in multiple templates to templates/helpers.php
@Mandalka Mandalka self-assigned this Oct 4, 2019
@Mandalka
Copy link
Collaborator Author

Mandalka commented Oct 4, 2019

Moved templates for text snippets and entities snippets from view list template to reusable view.snippets.text.php and view.snippets.entities.php in #62

@Mandalka
Copy link
Collaborator Author

Mandalka commented Oct 4, 2019 •
edited
Loading

(Re)Move multiple/same command (commands like open, annotate, preview) templates from multiple views to new reused view.commands.php

@Mandalka
Copy link
Collaborator Author

Mandalka commented Oct 4, 2019

Moved function filesize_formated for templates from index.php to templates/helpers.php

@Mandalka
Copy link
Collaborator Author

Mandalka commented Oct 5, 2019

(Re)Moved multiple/same url templates from multiple views to new reused helper function get_urls() and template view.url.php.

@Mandalka Mandalka closed this as completed Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mandalka Mandalka

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Mandalka