Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]Add multiple sources join query for PPL #1583

Open
YANG-DB opened this issue Apr 26, 2023 · 2 comments
Open

[FEATURE]Add multiple sources join query for PPL #1583

YANG-DB opened this issue Apr 26, 2023 · 2 comments
Labels
correlation enhancement New feature or request

Comments

@YANG-DB
Copy link
Member

YANG-DB commented Apr 26, 2023

Is your feature request related to a problem?
Currently PPL has a single-source query capability:

Example:

search source=account
| where age > 18
| fields firstname, lastname

What solution would you like?
In a similar manner for the SQL engine which accepts multiple indices (sources) to perform a query, PPL should also allow such capability - this will mainly benefit the join use case in which we are required to match documents according to similar dimensions .

Example:

search source=account, purchase
| where account.age > 18, account.id = purchase.accountId
| fields account.firstname, account.lastname, purchase.amount
| stats avg(purchase.amount);

Another important consideration is the fact that we aim to use PPL as the main Observability query language and this would mandate us to allow such join capability for Correlation between different signals...

What alternatives have you considered?
N/A

Do you have any additional context?

@YANG-DB YANG-DB added enhancement New feature or request untriaged labels Apr 26, 2023
@anirudha anirudha removed the untriaged label May 4, 2023
@YANG-DB YANG-DB changed the title [FEATURE]Add multiple sources for PPL [FEATURE]Add multiple sources join query for PPL May 23, 2023
@acarbonetto
Copy link
Collaborator

This may be blocked on a [BUG] on implicit joins that would probably exist on the PPL side: #683
We should consider https://github.com/Bit-Quill/opensearch-project-sql/pull/263/files as an initial concept for joins (within a single index). We should seriously consider against joining data between indexes or severely limiting this capability (see the trace-analytics use case: #892).

@YANG-DB
Copy link
Member Author

YANG-DB commented Oct 11, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correlation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants