From 8c17404d3264a5881cfa299706982e5b1d2c41bb Mon Sep 17 00:00:00 2001 From: currantw Date: Thu, 7 Nov 2024 22:15:46 -0800 Subject: [PATCH] Add missing unit test Signed-off-by: currantw --- .../data/value/OpenSearchExprIpValueTest.java | 28 +++++++++++-------- 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/opensearch/src/test/java/org/opensearch/sql/opensearch/data/value/OpenSearchExprIpValueTest.java b/opensearch/src/test/java/org/opensearch/sql/opensearch/data/value/OpenSearchExprIpValueTest.java index 38a4ad3199..8d23d4bd90 100644 --- a/opensearch/src/test/java/org/opensearch/sql/opensearch/data/value/OpenSearchExprIpValueTest.java +++ b/opensearch/src/test/java/org/opensearch/sql/opensearch/data/value/OpenSearchExprIpValueTest.java @@ -5,40 +5,44 @@ package org.opensearch.sql.opensearch.data.value; -import static org.junit.jupiter.api.Assertions.assertEquals; -import static org.junit.jupiter.api.Assertions.assertNotNull; -import static org.junit.jupiter.api.Assertions.assertTrue; +import static org.junit.jupiter.api.Assertions.*; import org.junit.jupiter.api.Test; import org.opensearch.sql.opensearch.data.type.OpenSearchIpType; public class OpenSearchExprIpValueTest { - private OpenSearchExprIpValue ipValue = new OpenSearchExprIpValue("192.168.0.1"); + private final String ipString = "192.168.0.1"; + private final OpenSearchExprIpValue ipValue = new OpenSearchExprIpValue(ipString); @Test - void value() { - assertEquals("192.168.0.1", ipValue.value()); + void testValue() { + assertEquals(ipString, ipValue.value()); } @Test - void type() { + void testType() { assertEquals(OpenSearchIpType.of(), ipValue.type()); } @Test - void compare() { - assertEquals(0, ipValue.compareTo(new OpenSearchExprIpValue("192.168.0.1"))); - assertEquals(ipValue, new OpenSearchExprIpValue("192.168.0.1")); + void testCompare() { + assertEquals(0, ipValue.compareTo(new OpenSearchExprIpValue(ipString))); + assertEquals(ipValue, new OpenSearchExprIpValue(ipString)); } @Test - void equal() { - assertTrue(ipValue.equal(new OpenSearchExprIpValue("192.168.0.1"))); + void testEqual() { + assertTrue(ipValue.equal(new OpenSearchExprIpValue(ipString))); } @Test void testHashCode() { assertNotNull(ipValue.hashCode()); } + + @Test + void testStringValue() { + assertEquals(ipString, ipValue.stringValue()); + } }