Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for 2.9.0.0 #2992

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Jul 11, 2023

Description

Add release notes for 2.9.0.0

  • Category

Documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <[email protected]>
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #2992 (9f02a31) into main (37aacdc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2992   +/-   ##
=========================================
  Coverage     62.31%   62.31%           
  Complexity     3369     3369           
=========================================
  Files           267      267           
  Lines         19772    19772           
  Branches       3355     3355           
=========================================
  Hits          12321    12321           
+ Misses         5807     5806    -1     
- Partials       1644     1645    +1     

see 3 files with indirect coverage changes

RyanL1997
RyanL1997 previously approved these changes Jul 11, 2023
willyborankin
willyborankin previously approved these changes Jul 11, 2023
@RyanL1997
Copy link
Collaborator

* What went wrong:
Execution failed for task ':compileTestJava'.
> Could not resolve all dependencies for configuration ':testCompileClasspath'.
   > Conflict found for the following module:
       - org.apache.logging.log4j:log4j-core between versions 2.20.0 and 2.17.1

This bwc failing is caused by the merge of: opensearch-project/OpenSearch#8307.

@RyanL1997 RyanL1997 added the backport 2.9 Backport to 2.9 branch label Jul 12, 2023
Signed-off-by: Craig Perkins <[email protected]>
@cwperks cwperks dismissed stale reviews from willyborankin and RyanL1997 via d69658f July 12, 2023 18:09
@cwperks
Copy link
Member Author

cwperks commented Jul 12, 2023

@opensearch-project/engineering-effectiveness This PR is stuck on failing bwc checks. Its stuck because its claiming mismatching log4j versions in 2.9. Security plugin expects 2.17.1, but its complaining that its conflicting with 2.20.0 somewhere.

I see in the maven snapshots repo that it also shows 2.20.0: https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/opensearch/2.9.0-SNAPSHOT/opensearch-2.9.0-20230712.171946-191.pom

But buildSrc/version.properties show 2.17.1: https://github.com/opensearch-project/OpenSearch/blob/2.9/buildSrc/version.properties#L16

Why does the 2.9.0 SNAPSHOT show 2.20.0?

@cwperks
Copy link
Member Author

cwperks commented Jul 12, 2023

@reta
Copy link
Collaborator

reta commented Jul 12, 2023

Something changed in build 191

@cwperks I think I know what was happening: when 2.9 was cut, the 2.x version was not changed but continued to get new pull request merged (so 2.9.0-SNAPSHOTs were published from 2.x and 2.9 at the same time), including log4j 2.20.0. The 2.x was bumped to 2.10.0-SNAPSHOT a few hours ago, once the new 2.9.0-SNAPSHOT becomes available, things should get back on track.

@cwperks
Copy link
Member Author

cwperks commented Jul 13, 2023

That explains it. Thank you @reta

@cwperks
Copy link
Member Author

cwperks commented Jul 13, 2023

The new errors are due to a recent core refactor. Working on stabilizing the main branch now.

@cwperks cwperks removed the backport 2.9 Backport to 2.9 branch label Jul 17, 2023
@davidlago davidlago merged commit f1be2d7 into opensearch-project:main Jul 18, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 18, 2023
* Add release notes for 2.9.0.0

Signed-off-by: Craig Perkins <[email protected]>

* Add new item to release notes

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit f1be2d7)
peternied pushed a commit that referenced this pull request Jul 18, 2023
* Add release notes for 2.9.0.0

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit f1be2d7)
Co-authored-by: Craig Perkins <[email protected]>
@prudhvigodithi prudhvigodithi added the v2.9.0 v2.9.0 label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch v2.9.0 v2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants