Add retry to bootstrap for windows related workflows #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <[email protected]>
derek-ho
force-pushed
the
retry-bootstrap
branch
from
2540adc to
a80de71
Compare
Signed-off-by: Derek Ho <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2047 +/- ##
=======================================
Coverage 69.46% 69.46%
=======================================
Files 96 96
Lines 2597 2597
Branches 379 386 +7
=======================================
Hits 1804 1804
Misses 699 699
Partials 94 94 ☔ View full report in Codecov by Sentry. |
derek-ho
requested review from
cliu123,
cwperks,
DarshitChanpura,
RyanL1997 and
stephen-crawford
as code owners
cwperks
approved these changes
Jul 24, 2024
DarshitChanpura
approved these changes
Jul 24, 2024
|
This run: https://github.com/opensearch-project/security-dashboards-plugin/actions/runs/10082047527/job/27875428537?pr=2047 shows that it is actually retrying windows network failures |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
* Add the retry in composite action and bump version Signed-off-by: Derek Ho <[email protected]> * Bump to v3 with retry support Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit 3d99901)
derek-ho
pushed a commit
that referenced
this pull request
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CI checks for integration and unit tests often fail on windows due to network issues. I created a new release of the setup opensearch dashboards action that retries network related actions. This consumes it in security dashboards repo.
Category
Enhancement
Why these changes are required?
Fix: #2046
What is the old behavior before changes and new behavior after changes?
Download steps are retried on failures now, before they weren't.
Issues Resolved
Fix: #2046
Testing
Existing tests pass
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.