Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Use hideLocalCluster flag to determine whether a dataSourceId must be present #2136

Open
DarshitChanpura opened this issue Oct 16, 2024 · 1 comment
Assignees
Labels

Comments

@DarshitChanpura
Copy link
Member

At present, the dataSourceId schema validation for a route is lax in the sense that a dataSourceId when not present, it falls back to "Local Cluster".

This validation should be updated to check for hideLocalCluster flag. If the flag is set to false, then check if dataSourceId is present and a non-empty string.

@DarshitChanpura DarshitChanpura changed the title [Improvement] Use hideLocalCluster provided by cluster to determine whether a dataSourceId must be present [Improvement] Use hideLocalCluster fflag to determine whether a dataSourceId must be present Oct 16, 2024
@DarshitChanpura DarshitChanpura changed the title [Improvement] Use hideLocalCluster fflag to determine whether a dataSourceId must be present [Improvement] Use hideLocalCluster flag to determine whether a dataSourceId must be present Oct 16, 2024
@cwperks cwperks added triaged and removed untriaged labels Oct 21, 2024
@cwperks
Copy link
Member

cwperks commented Oct 21, 2024

[Triage] @DarshitChanpura Should I assign this issue to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants