Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Mimic the pre-commit hooks from OpenSearch Dashboards #1539

Closed
cwperks opened this issue Aug 3, 2023 · 1 comment
Closed

[FEATURE] Mimic the pre-commit hooks from OpenSearch Dashboards #1539

cwperks opened this issue Aug 3, 2023 · 1 comment
Labels
enhancement New feature or request triaged

Comments

@cwperks
Copy link
Member

cwperks commented Aug 3, 2023

Is your feature request related to a problem?

There have been many instances of contributors pushing up code to review only to find issues with linting from failures in checks like Unit Tests and Integration Tests. In OpenSearch-Dashboards, automatic linting is performed as a pre-commit hook which ensures that there are no linting errors before pushing to a remote repository.

What solution would you like?

This repo should mimic the same pre-commit hooks as OSD. Feature is requested here: #1538 (comment)

Do you have any additional context?

I believe this is setup on osd:bootstrap here. I'm currently looking at other dashboards plugins repos to see if we can mimic a setup from another dashboards plugin repo.

@cwperks cwperks added enhancement New feature or request untriaged triaged and removed untriaged labels Aug 3, 2023
@derek-ho
Copy link
Collaborator

Completed this in: #1851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged
Projects
None yet
Development

No branches or pull requests

2 participants