[BUG] missing roles button doesn't do anything

[derek-ho]

• Clear all roles from a user
• Try to login as that user
• This button doesn't do anything/link you back to anything
• Can't login at all in general - is this expected/a bug? Should we prevent people from deleting all roles linked to a user if it breaks like this?

[cwperks]

Would it make sense for that button to be a logout button?

[stephen-crawford]

[Triage] Hi @derek-ho thank you for opening this issue. This issue seems like a good one to get some UX/UI input on. Marking as such.

For the time being we can just remove this missing role notification behavior to work as expected.

[kamingleung]

I also think a Logout button would be more appropriate for this specific case.

Follow-up question: Is this screen only shown to users with 0 roles? What about users that has no Dashboards access (if that possible)?

[leanneeliatra]

I am starting this issue, please assign me when possible, thanks.

[leanneeliatra]

I can also see the button/page if I directly visit the URL: http://localhost:5601/app/customerror/missing-role
Issue in progress.

[leanneeliatra]

Added a logout action to this button. See PR: #1564
& associated integration tests PR: opensearch-project/opensearch-dashboards-functional-test#830

[leanneeliatra]

I have merged in the updated changes from the main branch for the associated integration tests.

The fix for the bug is here, the cypress tests are failing on this pipeline. I am in communication about this.
Possible cause of failure

The fix for the associated tests are here. I am awaiting reviews and the cypress tests are failing. I am in communication about this also.
Possible cause of test failure

[davidlago]

@RyanL1997 could you please lend a hand here? Thanks!

[leanneeliatra]

@RyanL1997 is going to have a look at the cypress tests for me (thank you :) )

[leanneeliatra]

2 tickets are linked to this:

1. The bug fix itself
#1564

• @RyanL1997 has tested manually and the cypress tests are passing.
• I have requested very final reviews (hopefully) from the users the CI called out: cliu123, scrawfor99 and davidlago.
• I also sent slack messages to our channel (AWS Eliatra) so the reviews should be on the way hopefully.

2. The tests
opensearch-project/opensearch-dashboards-functional-test#830

• Also very final stages
• Kavilla has requested can I (Leanne) post screen shots of these test passing and what is ran against?
• Also could post a screen shot of the dashboard sanity tests result as it will help verify this PR doesn't interfere with other tests.
• I am on this, I have asked for clarification on how to run the 'dashboard sanity tests'

[leanneeliatra]

Update:

2 tickets are linked to this:

1. The bug fix itself
Merged
#1564

2. The tests
Need one final review - then it can be merged, I have requested this on the PR and in slack.
opensearch-project/opensearch-dashboards-functional-test#830

[leanneeliatra]

Update

Both the bugfix and the tests are merged now.
This ticket can be moved to done

[davidlago]

Thanks @leanneeliatra !