Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Pink Elephant #556

Closed
5 tasks done
BSFishy opened this issue Mar 2, 2023 · 2 comments
Closed
5 tasks done

Implement Pink Elephant #556

BSFishy opened this issue Mar 2, 2023 · 2 comments
Labels
enhancement New feature or request theming

Comments

@BSFishy
Copy link
Contributor

BSFishy commented Mar 2, 2023

As follow-up for #521, since we have an accepted proposal for Pink Elephant, here is the implementation items for Pink Elephant (and more broadly any theme in the future)

  • Create src/theme_pink_elephant.scss
    • This should be a copy of src/theme_dark.scss with line 13 changed to reflect Pink Elephant rather than dark theme
  • Create src/themes/oui/oui_colors_pink_elephant.scss
    • This should be a copy of src/themes/oui/oui_colors_dark.scss for now. These colors will change in the future
  • Create src-docs/src/theme_pink_elephant.scss
    • This should be a copy of src-docs/src/theme_dark.scss with line 16 changed to reflect Pink Elephant rather than dark theme
  • Add Pink Elephant to the list of themes (OUI_THEMES) in src/themes/themes.ts
    • text: Pink Elephant
    • value: pink-elephant
  • Register the theme in src-docs/src/index.js
    • Import the theme like the other themes:
      import themeLight from './theme_light.scss';
      import themeDark from './theme_dark.scss';
      import themeCascadiaLight from './theme_cascadia_light.scss';
      import themeCascadiaDark from './theme_cascadia_dark.scss';
    • Register the theme like the other themes:
      registerTheme('light', [themeLight]);
      registerTheme('dark', [themeDark]);
      registerTheme('cascadia-light', [themeCascadiaLight]);
      registerTheme('cascadia-dark', [themeCascadiaDark]);

The implementation of this task can be based off the work done here: main...BSFishy:oui:pink_elephant

@BSFishy BSFishy added enhancement New feature or request theming labels Mar 2, 2023
@seanneumann seanneumann pinned this issue Mar 3, 2023
@seanneumann seanneumann unpinned this issue Mar 3, 2023
@joshuarrrr
Copy link
Member

@BSFishy Can we close this now? Is there any work remaining to be done?

@BSFishy
Copy link
Contributor Author

BSFishy commented Jun 2, 2023

Yep, this should have been closed with #559

@BSFishy BSFishy closed this as completed Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request theming
Projects
Status: Done
Development

No branches or pull requests

3 participants