Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Query cannot run in active session as long as the concurrent active session reach to 10 #876

Open
LantaoJin opened this issue Nov 6, 2024 · 3 comments
Labels
bug Something isn't working sanity-0.6

Comments

@LantaoJin
Copy link
Member

What is the bug?
Got follow error message when submit query in an active session:
{ "status": 429, "error": { "type": "ConcurrencyLimitExceededException", "reason": "Too Many Requests", "details": "domain concurrent active session can not exceed 10" } }

This is a bug to fix, since we should check the limit in create session instead of submitting query in active session.

@LantaoJin LantaoJin added bug Something isn't working untriaged sanity-0.6 and removed untriaged labels Nov 6, 2024
@noCharger
Copy link
Collaborator

This is expected behavior. Please ref
opensearch-project/sql#2390 for details

@LantaoJin
Copy link
Member Author

LantaoJin commented Nov 7, 2024

@noCharger no. I don't think so. The limitation implementation in my option is not correct. The limit of total concurrent active sessions should only impact the 11th session. But currently, when there are 10 concurrent active sessions, all the 10 active sessions won't work as expected. For example, you are opening a session and submit queries in this only active session you have. Now someone else create 9 sessions. You will find your active active session (actually all 10 active sessions) become "inactive" suddenly.

@ykmr1224
Copy link
Collaborator

ykmr1224 commented Nov 8, 2024

@LantaoJin +1. So the leaseManager.borrow should be called when creating new session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sanity-0.6
Projects
None yet
Development

No branches or pull requests

3 participants