Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add distinct_count PPL command #484

Closed
anasalkouz opened this issue Jul 25, 2024 · 3 comments
Closed

[FEATURE] Add distinct_count PPL command #484

anasalkouz opened this issue Jul 25, 2024 · 3 comments
Labels
enhancement New feature or request Lang:PPL Pipe Processing Language support

Comments

@anasalkouz
Copy link
Member

anasalkouz commented Jul 25, 2024

This is part of the stats command with specific

@anasalkouz anasalkouz converted this from a draft issue Jul 25, 2024
@anasalkouz anasalkouz moved this to Todo in PPL Commands Jul 25, 2024
@anasalkouz anasalkouz added Lang:PPL Pipe Processing Language support enhancement New feature or request and removed untriaged labels Jul 25, 2024
@salyh
Copy link
Contributor

salyh commented Aug 9, 2024

It seems that the distinct_count stats function is already implemented but a) with bugs and b) without tests

I fixed the bugs and add a integ test:
eliatra@2ef5890

Not sure if i missed something but that makes it working for me.

cc @YANG-DB @anasalkouz If the code looks good for you, I am happy to open a PR

@YANG-DB
Copy link
Member

YANG-DB commented Aug 9, 2024

thanks @salyh
yes, please create a PR ...

@YANG-DB YANG-DB moved this from Todo to In Progress in PPL Commands Aug 13, 2024
@YANG-DB YANG-DB moved this from In Progress to InReview in PPL Commands Aug 16, 2024
@YANG-DB YANG-DB changed the title Add distinct_count PPL command [FEATURE] Add distinct_count PPL command Aug 16, 2024
@YANG-DB YANG-DB moved this from InReview to Done in PPL Commands Aug 21, 2024
@YANG-DB YANG-DB closed this as completed by moving to Done in PPL Commands Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Lang:PPL Pipe Processing Language support
Projects
Status: Done
Development

No branches or pull requests

3 participants