Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Create ReloadableExtension interface #330

Closed
minalsha opened this issue Jan 11, 2023 · 5 comments · Fixed by #575
Closed

[FEATURE] Create ReloadableExtension interface #330

minalsha opened this issue Jan 11, 2023 · 5 comments · Fixed by #575
Assignees
@nrakhay
Labels
CCI Part of the College Contributor Initiative enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@minalsha
Copy link
Collaborator

Is your feature request related to a problem?

Extension points (see #315) will be (optionally) implemented on Extensions. Eventually these points may need to be communicated to OpenSearch to be registered in the appropriate service or module.

Allowing extensions to inherit from appropriate interfaces depending on their type will match the current Plugin implementation.

What solution would you like?

Add a new interface ReloadableExtension with default implementations for extension points matching ReloadablePlugin.java.
@minalsha minalsha added enhancement New feature or request good first issue Good for newcomers labels Jan 11, 2023
@dbwiddis dbwiddis mentioned this issue Jan 20, 2023
Closed
@dbwiddis dbwiddis added the help wanted Extra attention is needed label Mar 1, 2023
@nrakhay
Copy link
Contributor

nrakhay commented Mar 15, 2023 •
edited
Loading

Hello!

Currently I'm considering to take this issue, but I have a question:

I have looked for similar issues in closed section, and it seems not that hard. However, I couldn't get where to find the ReloadablePlugin.java or the source to which I should refer while working on the issue. Could you please navigate me through this a bit?

@dbwiddis
Copy link
Member

Hey @nrakhay the plugin interfaces are on the OpenSearch repo:
https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/plugins/ReloadablePlugin.java

@nrakhay
Copy link
Contributor

nrakhay commented Mar 15, 2023

Oh, I see.

May you assign me to this one?

@nrakhay
Copy link
Contributor

nrakhay commented Mar 16, 2023

Can you see my PR?

@dbwiddis dbwiddis linked a pull request Mar 16, 2023 that will close this issue
[FEATURE] Create ReloadableExtension interface #575
Merged
@dbwiddis
Copy link
Member

Yep! And just reviewed it.

@minalsha minalsha added the CCI Part of the College Contributor Initiative label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nrakhay nrakhay

Labels
CCI Part of the College Contributor Initiative enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FEATURE] Create ReloadableExtension interface nrakhay/opensearch-sdk-java
3 participants
@dbwiddis @nrakhay @minalsha