Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Create RepositoryExtension interface #329

Closed
minalsha opened this issue Jan 11, 2023 · 6 comments
Closed

[FEATURE] Create RepositoryExtension interface #329

minalsha opened this issue Jan 11, 2023 · 6 comments
Assignees
Labels
CCI Part of the College Contributor Initiative enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@minalsha
Copy link
Collaborator

Is your feature request related to a problem?

Extension points (see #315) will be (optionally) implemented on Extensions. Eventually these points may need to be communicated to OpenSearch to be registered in the appropriate service or module.

Allowing extensions to inherit from appropriate interfaces depending on their type will match the current Plugin implementation.

What solution would you like?

Add a new interface RepositoryExtension with default implementations for extension points matching RepositoryPlugin.java.

@minalsha minalsha added enhancement New feature or request good first issue Good for newcomers labels Jan 11, 2023
@dbwiddis dbwiddis added the help wanted Extra attention is needed label Mar 1, 2023
@kokibas
Copy link
Contributor

kokibas commented Mar 14, 2023

Hello @dbwiddis I would like to take this issue

@kokibas
Copy link
Contributor

kokibas commented Mar 14, 2023

@dbwiddis I would like to ask a question about your video on this link https://youtu.be/26EXeg1l7yE?t=880 when creating an extension.yml file I didn't understand exactly where it needs to be located could you please specify the path to the project where it should be located

@kokibas
Copy link
Contributor

kokibas commented Mar 14, 2023

@dbwiddis I would like to ask a question about your video on this link https://youtu.be/26EXeg1l7yE?t=880 when creating an extension.yml file I didn't understand exactly where it needs to be located could you please specify the path to the project where it should be located since I don't have the /install/opensearch-3.0.0-SNAPSHOT file in the distribution/archives/linux-tar/build directory/

@dbwiddis
Copy link
Member

Hey @kokibas I just re-watched the video and somehow the screenshots of the log (around 20:00) aren't being shown. I may have made a mistake in the screen sharing!

But the main point is, if it's not loading you can look at the log file for a line indicating where it's looking for extensions.yml and not finding it, and that is your directory.

In my macOS install it's here:

~/git/OpenSearch/distribution/archives/darwin-tar/build/install/opensearch-3.0.0-SNAPSHOT/extensions

That directory may not exist if you haven't done a build, so you have to install it yourself. The darwin-tar part is a macOS thing, you may have a linux equivalent (linux-tar).

@kokibas
Copy link
Contributor

kokibas commented Mar 14, 2023

@dbwiddis #564

@kokibas
Copy link
Contributor

kokibas commented Mar 20, 2023

Hi @dbwiddis , I finally figured out git #586, can you check please

@minalsha minalsha added the CCI Part of the College Contributor Initiative label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCI Part of the College Contributor Initiative enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
4 participants