Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Create MapperExtension interface #327

Closed
minalsha opened this issue Jan 11, 2023 · 4 comments · Fixed by #546
Closed

[FEATURE] Create MapperExtension interface #327

minalsha opened this issue Jan 11, 2023 · 4 comments · Fixed by #546
Assignees
@Kuanysh-kst
Labels
CCI Part of the College Contributor Initiative enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@minalsha
Copy link
Collaborator

Is your feature request related to a problem?

Extension points (see #315) will be (optionally) implemented on Extensions. Eventually these points may need to be communicated to OpenSearch to be registered in the appropriate service or module.

Allowing extensions to inherit from appropriate interfaces depending on their type will match the current Plugin implementation.

What solution would you like?

Add a new interface MapperExtension with default implementations for extension points matching MapperPlugin.java.
@minalsha minalsha added enhancement New feature or request good first issue Good for newcomers labels Jan 11, 2023
@dbwiddis dbwiddis mentioned this issue Jan 20, 2023
Closed
@dbwiddis dbwiddis added the help wanted Extra attention is needed label Mar 1, 2023
@Kuanysh-kst
Copy link
Contributor

Hello @dbwiddis, I would like to take this issue

@Kuanysh-kst
Copy link
Contributor

#546

@Kuanysh-kst
Copy link
Contributor

Can I consider this issue finished?

@dbwiddis dbwiddis linked a pull request Mar 13, 2023 that will close this issue
Created the MapperExtension interface and added the MapperPlugin content #546
Merged
@dbwiddis
Copy link
Member

Can I consider this issue finished?

It's linked to this issue so it will automatically close when the PR is merged. No further action from you, but our review process requires two approvals.

@minalsha minalsha added the CCI Part of the College Contributor Initiative label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kuanysh-kst Kuanysh-kst

Labels
CCI Part of the College Contributor Initiative enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
3 participants
@dbwiddis @minalsha @Kuanysh-kst