Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE]Create CircuitBreakerExtension interface #322

Closed
minalsha opened this issue Jan 11, 2023 · 2 comments
Closed

[FEATURE]Create CircuitBreakerExtension interface #322

minalsha opened this issue Jan 11, 2023 · 2 comments
Assignees
@nassipkali
Labels
CCI Part of the College Contributor Initiative enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@minalsha
Copy link
Collaborator

minalsha commented Jan 11, 2023 •
edited
Loading

Is your feature request related to a problem?

Extension points (see #315) will be (optionally) implemented on Extensions. Eventually these points may need to be communicated to OpenSearch to be registered in the appropriate service or module.

Allowing extensions to inherit from appropriate interfaces depending on their type will match the current Plugin implementation.

What solution would you like?

Add a new interface CircuitBreakerExtension with default implementations for extension points matching CircuitBreakerPlugin.java.
@minalsha minalsha added enhancement New feature or request good first issue Good for newcomers labels Jan 11, 2023
@dbwiddis dbwiddis mentioned this issue Jan 20, 2023
Closed
@dbwiddis dbwiddis added the help wanted Extra attention is needed label Mar 1, 2023
@nassipkali
Copy link
Contributor

Hello @dbwiddis, I would like to take this issue

@nassipkali nassipkali mentioned this issue Mar 22, 2023
Merged
@dbwiddis dbwiddis added the CCI Part of the College Contributor Initiative label Mar 24, 2023
@nassipkali
Copy link
Contributor

@dbwiddis Can we close this issue?

@dbwiddis dbwiddis closed this as completed May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nassipkali nassipkali

Labels
CCI Part of the College Contributor Initiative enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dbwiddis @nassipkali @minalsha