Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual approval required for workflow run 9877903986: Release 3.4.0 #258

Closed
github-actions bot opened this issue Jul 11, 2024 · 6 comments
Closed

Manual approval required for workflow run 9877903986: Release 3.4.0 #258

github-actions bot opened this issue Jul 11, 2024 · 6 comments
Assignees
@dblock @nhtruong @jayeshathila @robsears @VachaShah @harshavamsi @VijayanB @vamshin

Comments

@github-actions
Copy link

Please approve or deny the release TAG: 3.4.0 COMMIT: 683a854

Workflow is pending manual review.
URL: https://api.github.com/opensearch-project/opensearch-ruby/actions/runs/9877903986

Required approvers: [VijayanB jayeshathila robsears vamshin dblock VachaShah nhtruong harshavamsi]

Respond "approved", "approve", "lgtm", "yes" to continue workflow or "denied", "deny", "no" to cancel.
@Earlopain
Copy link
Collaborator

Last one timed out #256. Required approvers got lowered to one person but I think this is still using the old workflow file.

@nhtruong
Copy link
Collaborator

approve

@nhtruong
Copy link
Collaborator

@dblock we should lower the number of reviewers and approvers for this repo to 1 like most other clients.

@dblock
Copy link
Member

dblock commented Jul 11, 2024

approved

@dblock
Copy link
Member

dblock commented Jul 11, 2024

We did in #257

@github-actions GitHub Actions
Copy link
Author

All approvers have approved, continuing workflow and closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dblock dblock

@nhtruong nhtruong

@jayeshathila jayeshathila

@robsears robsears

@VachaShah VachaShah

@harshavamsi harshavamsi

@VijayanB VijayanB

@vamshin vamshin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@dblock @nhtruong @jayeshathila @robsears @VachaShah @harshavamsi @VijayanB @Earlopain @vamshin