You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
delete_by_query_rethrottle.rb and delete_by_rethrottle.rb both define delete_by_query_rethrottle. This causes a ruby warning to be emitted when running with -w. Example output when running the test suite here:
[earlopain@DESKTOP-PC opensearch-ruby]$ RUBYOPT=-w bundle exec rake test:transport:unit
...
/home/earlopain/Documents/opensearch-ruby/lib/opensearch/api/actions/delete_by_rethrottle.rb:36: warning: method redefined; discarding old delete_by_query_rethrottle
/home/earlopain/Documents/opensearch-ruby/lib/opensearch/api/actions/delete_by_query_rethrottle.rb:37: warning: previous definition of delete_by_query_rethrottle was here
...
Finished in 0.20590s
109 tests, 236 assertions, 0 failures, 0 errors, 0 skips
Clearly one of these is wrong. I'm however not knowledgable enough to say what the correct version would be.
This doesn't actually impact me, apart from these messages appearing in my test logs when running tests with warnings in my own project.
The text was updated successfully, but these errors were encountered:
Nice catch. Looks like only delete_by_query_rethrottle shows up in the Spec. Also the name of the file should match the name of the action. So 2 reasons to delete delete_by_rethrottle.rb
What is the bug?
delete_by_query_rethrottle.rb
anddelete_by_rethrottle.rb
both definedelete_by_query_rethrottle
. This causes a ruby warning to be emitted when running with-w
. Example output when running the test suite here:Clearly one of these is wrong. I'm however not knowledgable enough to say what the correct version would be.
This doesn't actually impact me, apart from these messages appearing in my test logs when running tests with warnings in my own project.
The text was updated successfully, but these errors were encountered: