Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add option_method missing to aggregation #216

Closed
HolyWalley opened this issue Dec 13, 2023 · 2 comments
Closed

[FEATURE] Add option_method missing to aggregation #216

HolyWalley opened this issue Dec 13, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@HolyWalley
Copy link

HolyWalley commented Dec 13, 2023

Is your feature request related to a problem?

Currently aggregation DSL does not support (or does it?) missing option. In my case, I needed it for histogram aggregation, but it looks like it's might (?) be applied to any bucket aggregation.

What solution would you like?

It would be nice to have it

What alternatives have you considered?

Currently I wrote a refinement which specifically defines missing method to histogram aggregation, but it might make sense to do it for all (or, if not all aggregations support it, just to those, which does).

In both cases I can open a PR, just if we decide to add it to only particular ones, I'll need a list of those, which supports it (I'm quite new to open search)

@HolyWalley HolyWalley added enhancement New feature or request untriaged labels Dec 13, 2023
@nhtruong
Copy link
Collaborator

I believe it does https://github.com/opensearch-project/opensearch-ruby/blob/main/lib/opensearch/dsl/search/aggregations/missing.rb#L31-L50

Did this file not load for you for some reason?

@HolyWalley
Copy link
Author

Hey, thanks for the response
I checked and we use 2.1.0, will try to understand why and maybe update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants