-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROPOSAL] Merge ML APIs to opensearch-py #867
Comments
Seems reasonable. Note that the raw API calls to OpenSearch should be generated from spec in here, and not hand-written. |
CC: @minalsha |
@nathaliellenaa The ML plugin APIs are in https://github.com/opensearch-project/opensearch-api-specification/blob/main/spec/namespaces/ml.yaml with tests in https://github.com/opensearch-project/opensearch-api-specification/tree/main/tests/plugins/ml. According to opensearch-project/opensearch-api-specification#168 some are missing, which is where I'd start.
Then any of these that exist in opensearch-py-ml should be deleted ensuring backwards compatibility, and use the generated code in opensearch-py. |
I'll start by adding the missing Models APIs along with the tests. |
What are you proposing?
In regard to this proposal, we want to merge ML APIs from
opensearch-py-ml
toopensearch-py
.What problems are you trying to solve?
Currently, users need to install and manage two different packages when they want to use ML functionalities. By merging ML APIs to
opensearch-py
, users who want to use ML functionalities would only need to install and manage a single package, reducing their effort and confusion.What is the developer experience going to be?
The coordination of updates and releases for ML features will be easier. With ML APIs integrated into
opensearch-py
, the codebase management will be simplified. There is also opportunity to refactor and optimize ML APIs during the merger process.What is the user experience going to be?
Users only require a single package installation for both core OpenSearch operations and ML functionalities. It will simplify dependency management in their projects.
Are there breaking changes to the User Experience?
This change should not introduce breaking changes to the existing user experience. Users who currently use
opensearch-py-ml
for ML APIs might need to update their import statements, but the functionality and method signatures should remain the same.What will it take to execute?
opensearch-py-ml
toopensearch-py
, ensuring proper integration and maintaining existing functionality.opensearch-py
features.opensearch-py-ml
users.opensearch-py
package.The text was updated successfully, but these errors were encountered: