Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete_point_in_time implementation difference between Generated vs Existed client #501

Closed
Tracked by #489
saimedhi opened this issue Sep 16, 2023 · 0 comments
Closed
Tracked by #489

Comments

@saimedhi
Copy link
Collaborator

saimedhi commented Sep 16, 2023

Async/init delete_point_in_time

existing:

@query_params()
async def delete_point_in_time(self, body=None, all=False, params=None, headers=None):
    """
    Delete a point in time
    :arg body: a point-in-time id to delete
    :arg all: set it to `True` to delete all alive point in time.
    """
    path = (
        _make_path("_search", "point_in_time", "_all")
        if all
        else _make_path("_search", "point_in_time")
    )
    return await self.transport.perform_request(
        "DELETE", path, params=params, headers=headers, body=body
    )

generated:

@query_params()
async def delete_all_pits(self, params=None, headers=None):
    """
    Deletes all active point in time searches.
    """
    return await self.transport.perform_request(
        "DELETE", "/_search/point_in_time/_all", params=params, headers=headers
    )
    
    
@query_params()
async def delete_pit(self, body=None, params=None, headers=None):
    """
    Deletes one or more point in time searches based on the IDs passed.

    :arg body:
    """
    return await self.transport.perform_request(
        "DELETE",
        "/_search/point_in_time",
        params=params,
        headers=headers,
        body=body,
    )
@github-actions github-actions bot added the untriaged Need triage label Sep 16, 2023
@saimedhi saimedhi changed the title #### 6. APIs with major/complete differences delete_point_in_time implementation difference Sep 16, 2023
@saimedhi saimedhi changed the title delete_point_in_time implementation difference delete_point_in_time implementation difference between Generated vs Existed client Sep 16, 2023
@saimedhi saimedhi reopened this Sep 16, 2023
@saimedhi saimedhi removed the untriaged Need triage label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant