Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Guide] Document Lifecycle #352

Closed
Tracked by #355
nhtruong opened this issue Apr 4, 2023 · 7 comments
Closed
Tracked by #355

[Guide] Document Lifecycle #352

nhtruong opened this issue Apr 4, 2023 · 7 comments
Labels
CCI enhancement New feature or request good first issue Good for newcomers

Comments

@nhtruong
Copy link
Contributor

nhtruong commented Apr 4, 2023

Create guides/document_lifecycle.md similar to the Ruby guide

You must assure that:

  • All code-blocks, when run from start to finish in order they appear in the guide, do not throw any errors. If you want to demonstrate that certain statements will throw errors, they must be wrapped in a try/catch and print out the expected error.
  • All code-blocks are properly marked with the language it's written in (i.e. ```ruby)
  • The instructions, though mostly identical to the Ruby guide, are suitable for this repo.
@nhtruong nhtruong added enhancement New feature or request good first issue Good for newcomers untriaged Need triage CCI labels Apr 4, 2023
@nhtruong nhtruong mentioned this issue Apr 4, 2023
6 tasks
@nhtruong nhtruong removed the untriaged Need triage label Apr 4, 2023
@Nicksqain
Copy link
Contributor

@nhtruong I have made a PR to solve this issue #364

@tannerjones4075
Copy link

Have this issue been resolved? It looks like #364 has been resolved.

@saimedhi
Copy link
Collaborator

Hello @Nicksqain,

Would you like to co-author #364 with @tannerjones4075 or handle it on your own?

Thank you.

@tannerjones4075
Copy link

It looks like has already put in a MR. I will let @Nicksqain handle it.

@saimedhi
Copy link
Collaborator

@tannerjones4075, go ahead and finish the PR (including working sample) if you are interested :)

@Djcarrillo6
Copy link
Contributor

Djcarrillo6 commented Oct 19, 2023

Hi @saimedhi & @tannerjones4075, I went ahead to completed what was missing for this PR and I opened a new one here. @saimedhi this is similar to what I did last week for another open PR from Nick(who is not actively contributing at this time).

@dblock
Copy link
Member

dblock commented Nov 10, 2023

Closing via #559.

@dblock dblock closed this as completed Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCI enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants