-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add support for inclusive naming #174
Comments
Thank you @amoghtewari! Assigning you |
Hi @VachaShah , I was attempting to run the nox test suite and got the following error (limiting myself to Python 3.9 for now) Have you or anyone else encountered a similar message? Am I missing something obvious? |
Hi @amoghtewari, can you paste your repo link with the code changes and I can take a look? I have not seen this error for the nox command as of yet but would be helpful to look at the changes. |
Hi @VachaShah, here's my fork, https://github.com/amoghtewari/opensearch-py which I was able to test alongside the docker image with nox ( apparently the bugs were from not having set up the SSL certs so I disabled security since it has no intersection with my changes, was able to pass 65% of the tests, the failed ones required ssl), Please take a look and let me know if this works as expected. |
@amoghtewari can you raise a PR? It is easier to measure changes that way. Thanks. |
Hi @amoghtewari, are you planning on PR'ing this? Is there anything others could do to help you put it together for a PR? |
Hi @harshavamsi & @wbeckler , My apologies for the delay. |
Hi @amoghtewari, did you see the comments on your PR about the DCO? |
Yes. I'm swamped at work in the foreseeable future, so I request you to re-assign this issue. |
@amoghtewari @wbeckler I can create a PR on the fork to make the rest of the changes. |
Add support for inclusive naming by deprecating the master nomenclature.
See meta issue opensearch-project/opensearch-clients#16 for details.
The text was updated successfully, but these errors were encountered: