Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add support for inclusive naming #174

Closed
VachaShah opened this issue Jun 16, 2022 · 11 comments · Fixed by #243
Closed

[FEATURE] Add support for inclusive naming #174

VachaShah opened this issue Jun 16, 2022 · 11 comments · Fixed by #243
Assignees
Labels
enhancement New feature or request

Comments

@VachaShah
Copy link
Collaborator

Add support for inclusive naming by deprecating the master nomenclature.

See meta issue opensearch-project/opensearch-clients#16 for details.

@amoghtewari
Copy link

amoghtewari commented Jul 16, 2022

@VachaShah, I was able to list all files that have one or more occurrences of the string "master" (with the context mentioned in the meta issue). May I ask to be assigned this issue? I'll open a PR and make changes.

https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/_async/client/__init__.py
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/_async/client/__init__.pyi
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/_async/client/cat.py
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/_async/client/cat.pyi
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/_async/client/cluster.py
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/_async/client/cluster.pyi
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/_async/client/dangling_indices.py
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/_async/client/dangling_indices.pyi
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/_async/client/features.py
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/_async/client/features.pyi
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/_async/client/indices.py
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/_async/client/indices.pyi
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/_async/client/ingest.py
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/_async/client/ingest.pyi
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/_async/client/snapshot.py
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/_async/client/snapshot.pyi
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/client/__init__.py
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/client/__init__.pyi
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/client/cat.py
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/client/cat.pyi
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/client/cluster.py
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/client/cluster.pyi
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/client/dangling_indices.py
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/client/dangling_indices.pyi
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/client/features.py
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/client/features.pyi
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/client/indices.py
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/client/indices.pyi
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/client/ingest.py
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/client/ingest.pyi
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/client/snapshot.py
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/client/snapshot.pyi
https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/transport.py
https://github.com/opensearch-project/opensearch-py/blob/main/test_opensearchpy/test_async/test_transport.py
https://github.com/opensearch-project/opensearch-py/blob/main/test_opensearchpy/test_transport.py

@VachaShah
Copy link
Collaborator Author

Thank you @amoghtewari! Assigning you

@amoghtewari
Copy link

Hi @VachaShah , I was attempting to run the nox test suite and got the following error (limiting myself to Python 3.9 for now)

window

Have you or anyone else encountered a similar message? Am I missing something obvious?

@VachaShah
Copy link
Collaborator Author

Hi @amoghtewari, can you paste your repo link with the code changes and I can take a look? I have not seen this error for the nox command as of yet but would be helpful to look at the changes.

@amoghtewari
Copy link

Hi @VachaShah, here's my fork, https://github.com/amoghtewari/opensearch-py which I was able to test alongside the docker image with nox ( apparently the bugs were from not having set up the SSL certs so I disabled security since it has no intersection with my changes, was able to pass 65% of the tests, the failed ones required ssl), Please take a look and let me know if this works as expected.

@harshavamsi
Copy link
Collaborator

@amoghtewari can you raise a PR? It is easier to measure changes that way. Thanks.

@wbeckler
Copy link
Contributor

Hi @amoghtewari, are you planning on PR'ing this? Is there anything others could do to help you put it together for a PR?

@amoghtewari
Copy link

Hi @harshavamsi & @wbeckler , My apologies for the delay.
Here's the PR, please let me know what you think.
#212

@wbeckler
Copy link
Contributor

Hi @amoghtewari, did you see the comments on your PR about the DCO?

@amoghtewari
Copy link

Yes. I'm swamped at work in the foreseeable future, so I request you to re-assign this issue.

@harshavamsi
Copy link
Collaborator

@amoghtewari @wbeckler I can create a PR on the fork to make the rest of the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants