Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] remove Python 2 support #121

Closed
PhilipMay opened this issue Feb 5, 2022 · 7 comments
Closed

[PROPOSAL] remove Python 2 support #121

PhilipMay opened this issue Feb 5, 2022 · 7 comments

Comments

@PhilipMay
Copy link
Contributor

see this discussion: #120 (review)

This should be changed for example:

python-version: [2.7, 3.5, 3.6, 3.7, 3.8, 3.9]

@PhilipMay
Copy link
Contributor Author

what do you think @dtaivpp @VijayanB

@axeoman axeoman added untriaged Need triage and removed needs-triage labels Feb 14, 2022
@VijayanB
Copy link
Member

VijayanB commented Feb 15, 2022

Since python 2.x support is ended, i agree that we should also move forward with python 3.x support only. I am leaning towards creating next major version and remove python 2 support starting 2.0 and keep 1.x only for high severity security fixes.
@dblock Can you provide feedback?

@wbeckler
Copy link
Contributor

wbeckler commented Aug 5, 2022

@VijayanB Do you know if keeping python 2.7 in there is breaking anything in OpenSearch v 1.x today? E.g. is it causing flakier tests or build issues?

@PhilipMay
Copy link
Contributor Author

btw.: version 3.5 and 3.6 and also unsupported now...

@wbeckler wbeckler removed the untriaged Need triage label Oct 27, 2022
@wbeckler
Copy link
Contributor

Does anyone have other thoughts on the pros/cons of keeping these versions supported?

@dblock
Copy link
Member

dblock commented Oct 27, 2022

My general recommendation is to remove versions when they are both EOL and it's actually removing some kind of overhead (e.g. we can't adopt a syntax that's only Python 3.x), so I tend to do it while bumping a major version per semver because of other changes. It looks like EOL is true for Python <=3.6, so that's easy. Are there any actual advantages of removing 2.x support, or major changes we'd like to make that no longer work with older Python? @PhilipMay

@dblock
Copy link
Member

dblock commented Jul 26, 2023

Closing in favor of #430 which is just a more complete version of this.

@dblock dblock closed this as completed Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants