-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROPOSAL] remove Python 2 support #121
Comments
Since python 2.x support is ended, i agree that we should also move forward with python 3.x support only. I am leaning towards creating next major version and remove python 2 support starting 2.0 and keep 1.x only for high severity security fixes. |
@VijayanB Do you know if keeping python 2.7 in there is breaking anything in OpenSearch v 1.x today? E.g. is it causing flakier tests or build issues? |
btw.: version 3.5 and 3.6 and also unsupported now... |
Does anyone have other thoughts on the pros/cons of keeping these versions supported? |
My general recommendation is to remove versions when they are both EOL and it's actually removing some kind of overhead (e.g. we can't adopt a syntax that's only Python 3.x), so I tend to do it while bumping a major version per semver because of other changes. It looks like EOL is true for Python <=3.6, so that's easy. Are there any actual advantages of removing 2.x support, or major changes we'd like to make that no longer work with older Python? @PhilipMay |
Closing in favor of #430 which is just a more complete version of this. |
see this discussion: #120 (review)
This should be changed for example:
opensearch-py/.github/workflows/ci.yml
Line 42 in 4056fa0
The text was updated successfully, but these errors were encountered: