Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSAL] Request feedback on replacing ezimuel/ringphp #199

Open
jeabakker opened this issue Jun 5, 2024 · 11 comments · May be fixed by #233
Open

[PROPOSAL] Request feedback on replacing ezimuel/ringphp #199

jeabakker opened this issue Jun 5, 2024 · 11 comments · May be fixed by #233
Labels
enhancement New feature or request

Comments

@jeabakker
Copy link

What/Why

What are you proposing?

I've developed an OpenSearch plugin for my project (https://github.com/Elgg/Elgg). While trying to update my plugin I ran into a dependency conflict.
My project uses react/promise ~3.1, ezimuel/ringphp uses react/promise ~2.0 thus my dependency conflict. Since ezimuel/ringphp hasn't had an update in +/- 2 years and that was a fork of an abandoned project maybe it's time to replace it.

What users have asked for this feature?

This was already discussed in elasticsearch in 2020
elastic/elasticsearch-php#992
elastic/elasticsearch-php#990

What problems are you trying to solve?

A composer dependency conflict

Are there any security considerations?

Using maintained code is always better than using abandoned code

Are there any breaking changes to the API

Unknown, but is done correctly I don't see how

Are there breaking changes to the User Experience?

shouldn't be

Why should it be built? Any reason not to?

Using maintained code is always better than using abandoned code.

What will it take to execute?

Replace parts where RingPHP is used with new code

@jeabakker
Copy link
Author

@dblock
Copy link
Member

dblock commented Jun 5, 2024

Yes, we should replace it. Appreciate a PR!

Please make sure not to look at any non-APLv2-compatible code.

@dblock dblock added enhancement New feature or request and removed untriaged labels Jun 5, 2024
@stof
Copy link
Contributor

stof commented Aug 1, 2024

The Elasticsearch PHP client uses the MIT license.

@ryan-hovland
Copy link

See #219

@ryan-hovland
Copy link

I submitted a MR to ezimuel/ringphp to fix this in the meantime while a long term replacement is found. Hopefully the maintainer is still around.
ezimuel/ringphp#11

@dblock
Copy link
Member

dblock commented Aug 14, 2024

The last release was from 2022 so I am going to say it's unlikely :(

@stof
Copy link
Contributor

stof commented Aug 14, 2024

Ezimuel is the maintainer of the elasticsearch-php SDK. As that SDK stopped using ringphp in its version 8, I also think this is unlikely.

@kimpepper
Copy link
Contributor

As a library, we should not have a hard dependency on a HTTP client.

Instead we should move to using PSR-17 HTTP Message Interface, PSR-17 HTTP Factories and PSR-18 HTTP Client.

For composer dependencies we can use the virtual packages psr/http-client-implementation and php-http/async-client-implementation

This allows projects to re-use existing HTTP clients that support the PSR standards, and a avoids the issue we have now with unsupported transitive dependencies.

@dblock
Copy link
Member

dblock commented Oct 19, 2024

@kimpepper Yes. There's an unfinished PR for this in #228, but alternate implementations are welcome.

@kimpepper
Copy link
Contributor

I created an initial PR that does that #233

@kimpepper kimpepper linked a pull request Oct 22, 2024 that will close this issue
3 tasks
@flexiapp
Copy link

A lot of deprecation notices from ezimuel/ringphp on PHP8.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants