Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] add script_fields to _msearch queries #617

Closed
ts8ta opened this issue Sep 7, 2023 · 5 comments · Fixed by #632
Closed

[FEATURE] add script_fields to _msearch queries #617

ts8ta opened this issue Sep 7, 2023 · 5 comments · Fixed by #632
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ts8ta
Copy link

ts8ta commented Sep 7, 2023

Is your feature request related to a problem?

add "script_fields" to _msearch request

What solution would you like?

I need a way to add "script_fields" to my msearch request item. It looks like it is already possilbe with a single index seach request, but not in the MultiIndex Search.

@ts8ta ts8ta added enhancement New feature or request untriaged labels Sep 7, 2023
@ts8ta ts8ta changed the title [FEATURE] [FEATURE] add script_fields to _msearch queries Sep 7, 2023
@VachaShah
Copy link
Collaborator

Thank you @ts8ta for raising this issue. Want to try to implement this?

@VachaShah VachaShah added good first issue Good for newcomers and removed untriaged labels Sep 14, 2023
@ts8ta
Copy link
Author

ts8ta commented Sep 15, 2023

Hi @VachaShah , thanks for your message. I think I won't be able to look into this myself due to capacity reasons.

What is the usual way to get this implemented and how long would it take?

@VachaShah
Copy link
Collaborator

I worked on this to add script_fields to multi search and just raised a draft PR for it. However, for the test I am writing, I keep getting all shards failed error. I will look into it further, may be I am not adding the script fields in the test right 🤔 The draft PR is #632

@Shiv10122003
Copy link

hello i want to contribute

@VachaShah
Copy link
Collaborator

hello i want to contribute

Thank you @Shiv10122003 for your interest! This issue is resolved but we would love your contributions for other issues in the repo. Please check out some of the good first issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants